Changeset 209049 in webkit
- Timestamp:
- Nov 28, 2016 5:08:29 PM (7 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r209048 r209049 1 2016-11-28 Chris Dumez <cdumez@apple.com> 2 3 [Mac] Clicking on an HTML validation bubble should dismiss it 4 https://bugs.webkit.org/show_bug.cgi?id=165117 5 <rdar://problem/29409837> 6 7 Reviewed by Simon Fraser. 8 9 Clicking on an HTML validation bubble should dismiss it. It previously 10 did nothing. 11 12 No new tests, this is not easily testable as EventSender.keyDown() sends 13 the event to the view, not to a particular screen location. 14 15 * platform/mac/ValidationBubbleMac.mm: 16 (-[WebValidationPopover mouseDown:]): 17 (WebCore::ValidationBubble::ValidationBubble): 18 1 19 2016-11-27 Sam Weinig <sam@webkit.org> 2 20 -
trunk/Source/WebCore/platform/mac/ValidationBubbleMac.mm
r209016 r209049 32 32 #import <wtf/text/WTFString.h> 33 33 34 @interface WebValidationPopover : NSPopover 35 @end 36 37 @implementation WebValidationPopover 38 39 - (void)mouseDown:(NSEvent *)event 40 { 41 UNUSED_PARAM(event); 42 [self close]; 43 } 44 45 @end 46 34 47 namespace WebCore { 35 48 … … 60 73 [popoverView setFrame:NSMakeRect(0, 0, labelSize.width + horizontalPadding * 2, labelSize.height + verticalPadding * 2)]; 61 74 62 m_popover = adoptNS([[ NSPopover alloc] init]);75 m_popover = adoptNS([[WebValidationPopover alloc] init]); 63 76 [m_popover setContentViewController:controller.get()]; 64 77 [m_popover setBehavior:NSPopoverBehaviorTransient];
Note: See TracChangeset
for help on using the changeset viewer.