Changeset 209098 in webkit
- Timestamp:
- Nov 29, 2016 3:38:19 PM (7 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r209097 r209098 1 2016-11-29 Antoine Quint <graouts@apple.com> 2 3 [Modern Media Controls] Status text stuck saying "Loading" after media starts playing 4 https://bugs.webkit.org/show_bug.cgi?id=165162 5 6 Reviewed by Dean Jackson. 7 8 Adding a new test ensuring the status text is the empty string once the media starts playing. 9 10 * media/modern-media-controls/status-support/status-support-playing-expected.txt: Added. 11 * media/modern-media-controls/status-support/status-support-playing.html: Added. 12 1 13 2016-11-29 Ryan Haddad <ryanhaddad@apple.com> 2 14 -
trunk/Source/WebCore/ChangeLog
r209096 r209098 1 2016-11-29 Antoine Quint <graouts@apple.com> 2 3 [Modern Media Controls] Status text stuck saying "Loading" after media starts playing 4 https://bugs.webkit.org/show_bug.cgi?id=165162 5 6 Reviewed by Dean Jackson. 7 8 We forgot to handle the case where none of the special messages need to be set and the 9 status text should be just an empty string, meaning there is no status text shown in the 10 controls bar and the scrubber appears instead. 11 12 Test: media/modern-media-controls/status-support/status-support-playing.html 13 14 * Modules/modern-media-controls/media/status-support.js: 15 (StatusSupport.prototype.syncControl): 16 (StatusSupport): 17 1 18 2016-11-29 Brady Eidson <beidson@apple.com> 2 19 -
trunk/Source/WebCore/Modules/modern-media-controls/media/status-support.js
r208491 r209098 45 45 if (!!media.error) 46 46 this.control.text = "Error"; 47 if (media.duration === Number.POSITIVE_INFINITY && media.readyState >= HTMLMediaElement.HAVE_CURRENT_DATA)47 else if (media.duration === Number.POSITIVE_INFINITY && media.readyState >= HTMLMediaElement.HAVE_CURRENT_DATA) 48 48 this.control.text = "Live Broadcast"; 49 if (media.readyState <= HTMLMediaElement.HAVE_NOTHING && media.networkState === HTMLMediaElement.NETWORK_LOADING)49 else if (media.readyState <= HTMLMediaElement.HAVE_NOTHING && media.networkState === HTMLMediaElement.NETWORK_LOADING) 50 50 this.control.text = "Loading"; 51 else 52 this.control.text = ""; 51 53 } 52 54
Note: See TracChangeset
for help on using the changeset viewer.