Changeset 209099 in webkit

Timestamp:

Nov 29, 2016 3:38:40 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[Modern Media Controls] Inline controls show when entering fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=165161

Patch by Antoine Quint <Antoine Quint> on 2016-11-29
Reviewed by Dean Jackson.

We would error when entering fullscreen due to the TracksSupport having its destroy() method
called when tearing down the inline controls and the mediaController reference being incorrect.

• Modules/modern-media-controls/media/tracks-support.js:

(TracksSupport.prototype.destroy):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/modern-media-controls/media/tracks-support.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-11-29  Antoine Quint  <graouts@apple.com>
+
+        [Modern Media Controls] Inline controls show when entering fullscreen
+        https://bugs.webkit.org/show_bug.cgi?id=165161
+
+        Reviewed by Dean Jackson.
+
+        We would error when entering fullscreen due to the TracksSupport having its destroy() method
+        called when tearing down the inline controls and the `mediaController` reference being incorrect.
+
+        * Modules/modern-media-controls/media/tracks-support.js:
+        (TracksSupport.prototype.destroy):
+
 2016-11-29  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/Modules/modern-media-controls/media/tracks-support.js

@@ -47 +47 @@
         super.destroy();
 
-        const media = mediaController.media;
+        const media = this.mediaController.media;
         for (let tracks of [media.audioTracks, media.textTracks]) {
             for (let eventType of ["addtrack", "removetrack"])