Changeset 209157 in webkit

Timestamp:

Nov 30, 2016 2:59:28 PM (7 years ago)

Author:

beidson@apple.com

Message:

IndexedDB 2.0: Send operations off to the server in batches instead of one at a time.
​https://bugs.webkit.org/show_bug.cgi?id=165221

Reviewed by Myles C. Maxfield.

No new tests (No observable behavior change).

On a profile of "Lots of writes to an IndexedDB", timer scheduling/firing presented as over 10% of the time.

This patch negates much of that.

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::pendingOperationTimerFired): Send 100 operations off to the server

before spinning the runloop, instead of only 1.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/IDBTransaction.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-11-30  Brady Eidson  <beidson@apple.com>
+
+        IndexedDB 2.0: Send operations off to the server in batches instead of one at a time.
+        https://bugs.webkit.org/show_bug.cgi?id=165221
+
+        Reviewed by Myles C. Maxfield.
+
+        No new tests (No observable behavior change).
+
+        On a profile of "Lots of writes to an IndexedDB", timer scheduling/firing presented as over 10% of the time.
+
+        This patch negates much of that.
+
+        * Modules/indexeddb/IDBTransaction.cpp:
+        (WebCore::IDBTransaction::pendingOperationTimerFired): Send 100 operations off to the server
+          before spinning the runloop, instead of only 1.
+
 2016-11-30  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp

@@ -407 +407 @@
         return;
 
-    if (!m_pendingTransactionOperationQueue.isEmpty()) {
+    // We want to batch operations together without spinning the runloop for performance,
+    // but don't want to affect responsiveness of the main thread.
+    // This number is a good compromise in ad-hoc testing.
+    static const size_t operationBatchLimit = 128;
+
+    for (size_t iterations = 0; !m_pendingTransactionOperationQueue.isEmpty() && iterations < operationBatchLimit; ++iterations) {
         auto operation = m_pendingTransactionOperationQueue.takeFirst();
         m_transactionOperationsInProgressQueue.append(operation.get());
         operation->perform();
 
-        // If this operation we just started has an associated IDBRequest, we might be able to send
-        // another operation to the server before it completes.
-        if (operation->idbRequest() && !m_pendingTransactionOperationQueue.isEmpty())
-            schedulePendingOperationTimer();
-
-        return;
+        if (!operation->nextRequestCanGoToServer())
+            break;
+
     }