Changeset 209162 in webkit

Timestamp:

Nov 30, 2016 4:10:44 PM (7 years ago)

Author:

mark.lam@apple.com

Message:

TypeInfo::OutOfLineTypeFlags should be 16 bits in size.
​https://bugs.webkit.org/show_bug.cgi?id=165224

Reviewed by Saam Barati.

There's no reason for OutOfLineTypeFlags to be constraint to 8 bits since the
space is available to us. Making OutOfLineTypeFlags 16 bits brings TypeInfo up
to 32 bits in size from the current 24 bits.

• runtime/JSTypeInfo.h:

(JSC::TypeInfo::TypeInfo):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSTypeInfo.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-11-30  Mark Lam  <mark.lam@apple.com>
+
+        TypeInfo::OutOfLineTypeFlags should be 16 bits in size.
+        https://bugs.webkit.org/show_bug.cgi?id=165224
+
+        Reviewed by Saam Barati.
+
+        There's no reason for OutOfLineTypeFlags to be constraint to 8 bits since the
+        space is available to us.  Making OutOfLineTypeFlags 16 bits brings TypeInfo up
+        to 32 bits in size from the current 24 bits.
+
+        * runtime/JSTypeInfo.h:
+        (JSC::TypeInfo::TypeInfo):
+
 2016-11-30  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSTypeInfo.h

@@ -55 +55 @@
 public:
     typedef uint8_t InlineTypeFlags;
-    typedef uint8_t OutOfLineTypeFlags;
+    typedef uint16_t OutOfLineTypeFlags;
 
     TypeInfo(JSType type, unsigned flags = 0)
         : TypeInfo(type, flags & 0xff, flags >> 8)
     {
+        ASSERT(!(flags >> 24));
     }
 
@@ -111 +112 @@
     bool isSetOnFlags2(unsigned flag) const { ASSERT(flag >= (1 << 8)); return m_flags2 & (flag >> 8); }
 
-    unsigned char m_type;
-    unsigned char m_flags;
-    unsigned char m_flags2;
+    uint8_t m_type;
+    uint8_t m_flags;
+    uint16_t m_flags2;
 };