Changeset 20931 in webkit

Timestamp:

Apr 17, 2007 9:58:54 PM (17 years ago)

Author:

bdash

Message:

2007-04-17 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=13369 REGRESSION (r13366): Invisible table cell background is painted

Test: fast/table/invisible-cell-background.html

• rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): Don't paint any background if the cell is not visible. This behavior matches WinIE and Opera.

2007-04-17 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• pixel test for ​http://bugs.webkit.org/show_bug.cgi?id=13369 REGRESSION (r13366): Invisible table cell background is painted

• fast/table/invisible-cell-background-expected.checksum: Added.
• fast/table/invisible-cell-background-expected.png: Added.
• fast/table/invisible-cell-background-expected.txt: Added.
• fast/table/invisible-cell-background.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/table/invisible-cell-background-expected.checksum (added)
• LayoutTests/fast/table/invisible-cell-background-expected.png (added)
• LayoutTests/fast/table/invisible-cell-background-expected.txt (added)
• LayoutTests/fast/table/invisible-cell-background.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderTableCell.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-04-17  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13369
+          REGRESSION (r13366): Invisible table cell background is painted
+
+        * fast/table/invisible-cell-background-expected.checksum: Added.
+        * fast/table/invisible-cell-background-expected.png: Added.
+        * fast/table/invisible-cell-background-expected.txt: Added.
+        * fast/table/invisible-cell-background.html: Added.
+
 2007-04-17  Justin Garcia  <justin.garcia@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-04-17  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=13369
+          REGRESSION (r13366): Invisible table cell background is painted
+
+        Test: fast/table/invisible-cell-background.html
+
+        * rendering/RenderTableCell.cpp:
+        (WebCore::RenderTableCell::paintBackgroundsBehindCell): Don't paint any
+        background if the cell is not visible. This behavior matches WinIE and Opera.
+
 2007-04-17  Justin Garcia  <justin.garcia@apple.com>
 

trunk/WebCore/rendering/RenderTableCell.cpp

@@ -760 +760 @@
         return;
 
+    if (style()->visibility() != VISIBLE)
+        return;
+
     RenderTable* tableElt = table();
     if (!tableElt->collapseBorders() && style()->emptyCells() == HIDE && !firstChild())