Changeset 209855 in webkit


Ignore:
Timestamp:
Dec 14, 2016 9:15:11 PM (7 years ago)
Author:
rniwa@webkit.org
Message:

Web Inspector: Jumping to the definition of a custom elements is broken
https://bugs.webkit.org/show_bug.cgi?id=165890

Reviewed by Joseph Pecoraro.

Fix the regression from https://trac.webkit.org/changeset/208304.

  • UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._showCustomElementDefinition): Use the main target
since a custom element definition can never come from a worker.

Location:
trunk/Source/WebInspectorUI
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r209834 r209855  
     12016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Web Inspector: Jumping to the definition of a custom elements is broken
     4        https://bugs.webkit.org/show_bug.cgi?id=165890
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        Fix the regression from https://trac.webkit.org/changeset/208304.
     9
     10        * UserInterface/Views/DOMTreeElement.js:
     11        (WebInspector.DOMTreeElement.prototype._showCustomElementDefinition): Use the main target
     12        since a custom element definition can never come from a worker.
     13
    1142016-12-14  Matt Baker  <mattbaker@apple.com>
    215
  • trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js

    r208218 r209855  
    15101510
    15111511                    let location = response.location;
    1512                     let sourceCode = WebInspector.debuggerManager.scriptForIdentifier(location.scriptId);
     1512                    let sourceCode = WebInspector.debuggerManager.scriptForIdentifier(location.scriptId, WebInspector.mainTarget);
    15131513                    if (!sourceCode)
    15141514                        return;
Note: See TracChangeset for help on using the changeset viewer.