Changeset 209891 in webkit


Ignore:
Timestamp:
Dec 15, 2016 5:06:02 PM (7 years ago)
Author:
keith_miller@apple.com
Message:

Wasm should not create empty unlinked callsites
https://bugs.webkit.org/show_bug.cgi?id=165933

Reviewed by Mark Lam.

JSTests:

  • wasm/function-tests/dead-call.js: Added.

Source/JavaScriptCore:

Wasm would create holes in the unlinked callsite vector if B3 was able to
eliminate the callsite.

  • wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addCall):

Location:
trunk
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/JSTests/ChangeLog

    r209880 r209891  
     12016-12-15  Keith Miller  <keith_miller@apple.com>
     2
     3        Wasm should not create empty unlinked callsites
     4        https://bugs.webkit.org/show_bug.cgi?id=165933
     5
     6        Reviewed by Mark Lam.
     7
     8        * wasm/function-tests/dead-call.js: Added.
     9
    1102016-12-15  JF Bastien  <jfbastien@apple.com>
    211
  • trunk/Source/JavaScriptCore/ChangeLog

    r209880 r209891  
     12016-12-15  Keith Miller  <keith_miller@apple.com>
     2
     3        Wasm should not create empty unlinked callsites
     4        https://bugs.webkit.org/show_bug.cgi?id=165933
     5
     6        Reviewed by Mark Lam.
     7
     8        Wasm would create holes in the unlinked callsite vector if B3 was able to
     9        eliminate the callsite.
     10
     11        * wasm/WasmB3IRGenerator.cpp:
     12        (JSC::Wasm::B3IRGenerator::addCall):
     13
    1142016-12-15  JF Bastien  <jfbastien@apple.com>
    215
  • trunk/Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp

    r209880 r209891  
    701701    Type returnType = signature->returnType;
    702702
    703     size_t callIndex = m_unlinkedWasmToWasmCalls.size();
    704     m_unlinkedWasmToWasmCalls.grow(callIndex + 1);
    705703    result = wasmCallingConvention().setupCall(m_proc, m_currentBlock, Origin(), args, toB3Type(returnType),
    706704        [&] (PatchpointValue* patchpoint) {
     
    714712
    715713                jit.addLinkTask([=] (LinkBuffer& linkBuffer) {
    716                     m_unlinkedWasmToWasmCalls[callIndex] = { linkBuffer.locationOf(call), functionIndex };
     714                    m_unlinkedWasmToWasmCalls.append({ linkBuffer.locationOf(call), functionIndex });
    717715                });
    718716            });
Note: See TracChangeset for help on using the changeset viewer.