Changeset 209902 in webkit

Timestamp:

Dec 15, 2016 7:35:54 PM (7 years ago)

Author:

dbates@webkit.org

Message:

check-style should not complain about code in icu directories
​https://bugs.webkit.org/show_bug.cgi?id=53929

Reviewed by Darin Adler.

Skip style checking of imported ICU headers to avoid a deluge of style issues
as they do not conform to the WebKit Code Style guideline. We want to preserve
the formatting of these headers so as to make it straightforward to merge
changes to them, if necessary.

• Scripts/webkitpy/style/checker.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checker.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-12-15  Daniel Bates  <dabates@apple.com>
+
+        check-style should not complain about code in icu directories
+        https://bugs.webkit.org/show_bug.cgi?id=53929
+
+        Reviewed by Darin Adler.
+
+        Skip style checking of imported ICU headers to avoid a deluge of style issues
+        as they do not conform to the WebKit Code Style guideline. We want to preserve
+        the formatting of these headers so as to make it straightforward to merge
+        changes to them, if necessary.
+
+        * Scripts/webkitpy/style/checker.py:
+
 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/Scripts/webkitpy/style/checker.py

@@ -316 +316 @@
 _SKIPPED_FILES_WITHOUT_WARNING = [
     "LayoutTests" + os.path.sep,
+
     # Files generated by the bindings script should not be checked for style.
-    os.path.join('Source', 'WebCore', 'bindings', 'scripts', 'test')]
+    os.path.join('Source', 'WebCore', 'bindings', 'scripts', 'test'),
+
+    # ICU headers are imported.
+    os.path.join('Source', 'JavaScriptCore', 'icu'),
+    os.path.join('Source', 'WebCore', 'icu'),
+    os.path.join('Source', 'WebKit', 'mac', 'icu'),
+    os.path.join('Source', 'WTF', 'icu'),
+    ]
 
 # Extensions of files which are allowed to contain carriage returns.