Changeset 20993 in webkit

Timestamp:

Apr 21, 2007 1:14:25 AM (17 years ago)

Author:

bdash

Message:

2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=13417 Repro crash when the first argument to getMatchedCSSRules is not an element

Test: fast/dom/Window/getMatchedCSSRules-null-crash.html

• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::styleRulesForElement): Added null check.

2007-04-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=13417 Repro crash when the first argument to getMatchedCSSRules is not an element

• fast/dom/Window/getMatchedCSSRules-null-crash-expected.txt: Added.
• fast/dom/Window/getMatchedCSSRules-null-crash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/Window/getMatchedCSSRules-null-crash-expected.txt (added)
• LayoutTests/fast/dom/Window/getMatchedCSSRules-null-crash.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/cssstyleselector.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-04-21  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=13417
+          Repro crash when the first argument to getMatchedCSSRules is not an element
+
+        * fast/dom/Window/getMatchedCSSRules-null-crash-expected.txt: Added.
+        * fast/dom/Window/getMatchedCSSRules-null-crash.html: Added.
+
 2007-04-20  Beth Dakin  <bdakin@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-04-21  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=13417
+          Repro crash when the first argument to getMatchedCSSRules is not an element
+
+        Test: fast/dom/Window/getMatchedCSSRules-null-crash.html
+
+        * css/cssstyleselector.cpp:
+        (WebCore::CSSStyleSelector::styleRulesForElement): Added null check.
+
 2007-04-21  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebCore/css/cssstyleselector.cpp

@@ -1177 +1177 @@
 RefPtr<CSSRuleList> CSSStyleSelector::styleRulesForElement(Element* e, bool authorOnly)
 {
-    if (!e->document()->haveStylesheetsLoaded())
+    if (!e || !e->document()->haveStylesheetsLoaded())
         return 0;