Changeset 209945 in webkit

Timestamp:

Dec 16, 2016 3:17:42 PM (7 years ago)

Author:

Chris Dumez

Message:

[iOS] Align HTML from validation popover style with Copy/Paste callout bar
​https://bugs.webkit.org/show_bug.cgi?id=165973
<rdar://problem/29336638>

Reviewed by Simon Fraser.

Tweak font size and padding of the HTML from validation popover to
match the style of the Copy/Paste callout bar on iOS.

• platform/ios/ValidationBubbleIOS.mm:

(WebCore::ValidationBubble::ValidationBubble):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/ValidationBubbleIOS.mm (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-12-16  Chris Dumez  <cdumez@apple.com>
+
+        [iOS] Align HTML from validation popover style with Copy/Paste callout bar
+        https://bugs.webkit.org/show_bug.cgi?id=165973
+        <rdar://problem/29336638>
+
+        Reviewed by Simon Fraser.
+
+        Tweak font size and padding of the HTML from validation popover to
+        match the style of the Copy/Paste callout bar on iOS.
+
+        * platform/ios/ValidationBubbleIOS.mm:
+        (WebCore::ValidationBubble::ValidationBubble):
+
 2016-12-16  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/platform/ios/ValidationBubbleIOS.mm

@@ -35 +35 @@
 
 SOFT_LINK_FRAMEWORK(UIKit);
+SOFT_LINK_CLASS(UIKit, UIFont);
 SOFT_LINK_CLASS(UIKit, UILabel);
 SOFT_LINK_CLASS(UIKit, UIPopoverPresentationController);
@@ -93 +94 @@
 namespace WebCore {
 
-static const CGFloat horizontalPadding = 8;
-static const CGFloat verticalPadding = 8;
+static const CGFloat horizontalPadding = 17;
+static const CGFloat verticalPadding = 9;
 static const CGFloat maxLabelWidth = 300;
 
@@ -110 +111 @@
     RetainPtr<UILabel> label = adoptNS([[getUILabelClass() alloc] initWithFrame:CGRectZero]);
     [label setText:message];
+    [label setFont:[getUIFontClass() systemFontOfSize:14.0]];
     [label setLineBreakMode:NSLineBreakByWordWrapping];
     [label setNumberOfLines:4];