Changeset 209963 in webkit

Timestamp:

Dec 17, 2016 9:14:03 AM (7 years ago)

Author:

sbarati@apple.com

Message:

WebAssembly: Change a RELEASE_ASSERT_NOT_REACHED to a jit.breakpoint() for now to allow us to run some wasm benchmarks
​https://bugs.webkit.org/show_bug.cgi?id=165990

Reviewed by Mark Lam.

• wasm/WasmBinding.cpp:

(JSC::Wasm::importStubGenerator):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wasm/WasmBinding.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-12-17  Saam Barati  <sbarati@apple.com>
+
+        WebAssembly: Change a RELEASE_ASSERT_NOT_REACHED to a jit.breakpoint() for now to allow us to run some wasm benchmarks
+        https://bugs.webkit.org/show_bug.cgi?id=165990
+
+        Reviewed by Mark Lam.
+
+        * wasm/WasmBinding.cpp:
+        (JSC::Wasm::importStubGenerator):
+
 2016-12-16  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/JavaScriptCore/wasm/WasmBinding.cpp

@@ -79 +79 @@
         case Anyfunc:
         case I64:
-            // For the JavaScript embedding, imports with these types in their signature arguments are a WebAssembly.Module validation error.
-            RELEASE_ASSERT_NOT_REACHED();
+            // FIXME: Figure out the correct behavior here. I suspect we want such a stub to throw an exception immediately
+            // if called. https://bugs.webkit.org/show_bug.cgi?id=165991
+            jit.breakpoint();
             break;
         case I32: {