Changeset 209998 in webkit

Timestamp:

Dec 19, 2016 2:45:02 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Assertion seen in InspectorDebuggerAgent::refAsyncCallData with Inspector open
​https://bugs.webkit.org/show_bug.cgi?id=166034
<rdar://problem/29554366>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-12-19
Reviewed by Brian Burg.

• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::refAsyncCallData):
Remove assertion. This assert can happen if the currently executing callback
was just explicitly cancelled by script. Existing code already handles if
no async data was found for the given identifier.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/agents/InspectorDebuggerAgent.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-12-19  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Assertion seen in InspectorDebuggerAgent::refAsyncCallData with Inspector open
+        https://bugs.webkit.org/show_bug.cgi?id=166034
+        <rdar://problem/29554366>
+
+        Reviewed by Brian Burg.
+
+        * inspector/agents/InspectorDebuggerAgent.cpp:
+        (Inspector::InspectorDebuggerAgent::refAsyncCallData):
+        Remove assertion. This assert can happen if the currently executing callback
+        was just explicitly cancelled by script. Existing code already handles if
+        no async data was found for the given identifier.
+
 2016-12-18  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp

@@ -1143 +1143 @@
 {
     auto iterator = m_asyncCallIdentifierToData.find(identifier);
-    ASSERT(iterator != m_asyncCallIdentifierToData.end());
     if (iterator == m_asyncCallIdentifierToData.end())
         return;