Changeset 210095 in webkit

Timestamp:

Dec 21, 2016 7:06:35 PM (7 years ago)

Author:

timothy_horton@apple.com

Message:

TileGrid revalidates tiles twice during flush, first with wrong visible rect
​https://bugs.webkit.org/show_bug.cgi?id=166406

Reviewed by Simon Fraser.

No new tests; existing tests cover this code, this is just a perf win,
specifically reducing the amount of layer churn during zooming.

• platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::setScale):
Schedule a revalidation, which will happen later in the same flush,
instead of doing it immediately. Doing it immediately is problematic,
because we're currently in the middle of a GraphicsLayer tree flush,
and don't have the complete picture of the new state yet. We're guaranteed
to get the new scale *before* the flush calls revalidateTiles.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/ca/TileGrid.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-12-21  Tim Horton  <timothy_horton@apple.com>
+
+        TileGrid revalidates tiles twice during flush, first with wrong visible rect
+        https://bugs.webkit.org/show_bug.cgi?id=166406
+
+        Reviewed by Simon Fraser.
+
+        No new tests; existing tests cover this code, this is just a perf win,
+        specifically reducing the amount of layer churn during zooming.
+
+        * platform/graphics/ca/TileGrid.cpp:
+        (WebCore::TileGrid::setScale):
+        Schedule a revalidation, which will happen later in the same flush,
+        instead of doing it immediately. Doing it immediately is problematic,
+        because we're currently in the middle of a GraphicsLayer tree flush,
+        and don't have the complete picture of the new state yet. We're guaranteed
+        to get the new scale *before* the flush calls revalidateTiles.
+
 2016-12-21  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp

@@ -79 +79 @@
     m_containerLayer->setTransform(transform);
 
-    // FIXME: we may revalidateTiles twice in this commit.
-    revalidateTiles(PruneSecondaryTiles);
+    m_controller.setNeedsRevalidateTiles();
 
     m_containerLayer.get().setContentsScale(m_controller.deviceScaleFactor());