Changeset 210234 in webkit


Ignore:
Timestamp:
Jan 3, 2017 1:04:20 AM (7 years ago)
Author:
Carlos Garcia Campos
Message:

[GTK] HTTP auth layout tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=158919

Reviewed by Michael Catanzaro.

Source/WebKit2:

Implement NetworkSession::clearCredentials() for soup using the new libsoup API when available.

  • NetworkProcess/soup/NetworkSessionSoup.cpp:

(WebKit::NetworkSessionSoup::clearCredentials):

  • NetworkProcess/soup/NetworkSessionSoup.h:

Tools:

  • gtk/jhbuild.modules: Update libsoup to version 2.57.1.
  • gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need

introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
missing valac in the bots.

LayoutTests:

Unskip tests that should pass now.

  • platform/gtk/TestExpectations:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r210222 r210234  
     12017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK] HTTP auth layout tests are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=158919
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        Unskip tests that should pass now.
     9
     10        * platform/gtk/TestExpectations:
     11
    1122017-01-02  Chris Fleizach  <cfleizach@apple.com>
    213

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r210200 r210234  
    13241324webkit.org/b/158918 fast/css3-text/css3-text-decoration/text-decoration-dotted.html [ ImageOnlyFailure Pass ]
    13251325
    1326 webkit.org/b/158919 http/tests/loading/basic-auth-resend-wrong-credentials.html [ Failure Pass ]
    1327 webkit.org/b/158919 http/tests/loading/basic-credentials-sent-automatically.html [ Failure Pass ]
    1328 
    13291326# This test relies on iOS-specific font fallback.
    13301327fast/text/arabic-blacklisted-expected.html [ Pass ImageOnlyFailure ]

  • trunk/Source/WebKit2/ChangeLog

    r210221 r210234  
     12017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK] HTTP auth layout tests are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=158919
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        Implement NetworkSession::clearCredentials() for soup using the new libsoup API when available.
     9
     10        * NetworkProcess/soup/NetworkSessionSoup.cpp:
     11        (WebKit::NetworkSessionSoup::clearCredentials):
     12        * NetworkProcess/soup/NetworkSessionSoup.h:
     13
    1142017-01-01  Jeff Miller  <jeffm@apple.com>
    215

  • trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.cpp

    r208388 r210234  
    2929#include <WebCore/NetworkStorageSession.h>
    3030#include <WebCore/SoupNetworkSession.h>
     31#include <libsoup/soup.h>
    3132
    3233using namespace WebCore;
    … …  
    4849}
    4950
     51void NetworkSessionSoup::clearCredentials()
     52{
     53#if SOUP_CHECK_VERSION(2, 57, 1)
     54    soup_auth_manager_clear_cached_credentials(SOUP_AUTH_MANAGER(soup_session_get_feature(soupSession(), SOUP_TYPE_AUTH_MANAGER)));
     55#endif
     56}
     57
    5058} // namespace WebKit

  • trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.h

    r208388 r210234  
    4444private:
    4545    NetworkSessionSoup(WebCore::SessionID);
     46
     47    void clearCredentials() override;
    4648};
    4749

  • trunk/Tools/ChangeLog

    r210233 r210234  
     12017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK] HTTP auth layout tests are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=158919
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
     9        * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
     10        introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
     11        missing valac in the bots.
     12
    1132017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
    214

  • trunk/Tools/gtk/jhbuild.modules

    r209859 r210234  
    237237      <dep package="glib-networking"/>
    238238    </dependencies>
    239     <branch module="libsoup" version="2.49.91.1"
     239    <branch module="libsoup" version="2.57.1"
    240240            repo="git.gnome.org"
    241             tag="f7292448160128b3cb4b7cd06c2447f81fd8c6c9"/>
     241            tag="6acdbacc107c99fe6f05b78b81f4a40fb3fde9e9"/>
    242242  </autotools>
    243243

  • trunk/Tools/gtk/jhbuildrc

    r204279 r210234  
    2727import common
    2828
    29 # We always enable introspection so that we can sniff out problems with our
    30 # annotations sooner rather than later.
    31 autogenargs='--enable-introspection'
    32 
    3329# LLVM requires that builddir != srcdir, and it's not possible to do that in jhbuild only
    3430# for a module, so we do it here globally since it's a good idea for all other modules as well.
Note: See TracChangeset for help on using the changeset viewer.