Changeset 210328 in webkit

Timestamp:

Jan 5, 2017 7:51:39 AM (7 years ago)

Author:

Wenson Hsieh

Message:

Disable smooth playhead animation for main content media in the Touch Bar
​https://bugs.webkit.org/show_bug.cgi?id=166715
<rdar://problem/29870673>

Reviewed by Eric Carlson.

Passing in a non-zero playback rate to WebPlaybackControlsManager's timing property causes unintended effects
further down the stack. Please see the Radar for more details.

• platform/mac/WebPlaybackSessionInterfaceMac.mm:

(WebCore::WebPlaybackSessionInterfaceMac::updatePlaybackControlsManagerTiming):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/WebPlaybackSessionInterfaceMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Disable smooth playhead animation for main content media in the Touch Bar
+        https://bugs.webkit.org/show_bug.cgi?id=166715
+        <rdar://problem/29870673>
+
+        Reviewed by Eric Carlson.
+
+        Passing in a non-zero playback rate to WebPlaybackControlsManager's timing property causes unintended effects
+        further down the stack. Please see the Radar for more details.
+
+        * platform/mac/WebPlaybackSessionInterfaceMac.mm:
+        (WebCore::WebPlaybackSessionInterfaceMac::updatePlaybackControlsManagerTiming):
+
 2017-01-05  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/platform/mac/WebPlaybackSessionInterfaceMac.mm

@@ -221 +221 @@
         effectivePlaybackRate = 0;
 
-    manager.timing = [getAVValueTimingClass() valueTimingWithAnchorValue:currentTime anchorTimeStamp:effectiveAnchorTime rate:effectivePlaybackRate];
+    // FIXME: The timing value should ideally use the effective playback rate, but this causes AVKit to indefinitely fire a repeating timer.
+    // More investigation will be required before we re-enable smooth playhead animation -- for now, we should just pretend that the playback
+    // rate is always 0.
+    manager.timing = [getAVValueTimingClass() valueTimingWithAnchorValue:currentTime anchorTimeStamp:effectiveAnchorTime rate:0];
 }