Changeset 21046 in webkit

Timestamp:

Apr 23, 2007 2:24:50 PM (17 years ago)

Author:

adele

Message:

Reviewed by Adam.

Updating test from last checkin to include test case for select with and without a form element.

• fast/events/onchange-select-popup-expected.txt:
• fast/events/onchange-select-popup.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/onchange-select-popup-expected.txt (modified) (1 diff)
• fast/events/onchange-select-popup.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ -1 +1 @@
 2007-04-23  Adele Peterson  <adele@apple.com>
 
+        Reviewed by Adam.
+
+        Updating test from last checkin to include test case for select with and without a form element.
+
+        * fast/events/onchange-select-popup-expected.txt:
+        * fast/events/onchange-select-popup.html:
+
+2007-04-23  Adele Peterson  <adele@apple.com>
+
         Reviewed by Hyatt & Adam.
 
         Tests for <rdar://problem/4807799> REGRESSION: calling select() in onSearch handler doesn't work if you hit enter to trigger the event
+              and <rdar://problem/5153970> onChange doesn't fire when focusing a popup, using type-ahead to select, and leaving
 
         * fast/events/onchange-passwordfield-expected.txt:

trunk/LayoutTests/fast/events/onchange-select-popup-expected.txt

@@ -1 +1 @@
 This test verifies that the ENTER key fires the change event for popups.
+
 
 
 PASS: change event fired.
 
+blur event fired.
 
+

trunk/LayoutTests/fast/events/onchange-select-popup.html

@@ -19 +19 @@
     function test()
     {
-        var menu = document.getElementById('menu');
-        menu.focus();
+        if (window.layoutTestController)
+            layoutTestController.dumpAsText();
+        
+        // Test for select that's not inside a form element
+        var menu1 = document.getElementById('menu1');
+        menu1.focus();
 
         if (window.layoutTestController) {
-            layoutTestController.dumpAsText();
-
             // change the option selection
             eventSender.keyDown('e');
         }
-
         // hit enter
         var enterEvent = document.createEvent("KeyboardEvents");
         enterEvent.initKeyboardEvent("keypress", true, false, window, "Enter", 0, false, false, false, false, false);
-        menu.dispatchEvent(enterEvent);
+        menu1.dispatchEvent(enterEvent);
+        
+        // Test for select is inside a form element
+        var menu2 = document.getElementById('menu2');
+        menu2.focus();
+
+        if (window.layoutTestController) {
+            // change the option selection
+            eventSender.keyDown('e');
+        }
+        // hit enter
+        menu2.dispatchEvent(enterEvent);
     }
     </script>
@@ -39 +51 @@
     <p>This test verifies that the ENTER key fires the change event for popups.</p>
     <hr>
-    <form>
-        <select id="menu" onchange="changeHandler()" onblur="blurHandler()"><option>abcd</option><option>efgh</option></select>
+    <select id="menu1" onchange="changeHandler()" onblur="blurHandler()"><option>abcd</option><option>efgh</option></select>
+    <form onsubmit="return false;">
+        <select id="menu2" onchange="changeHandler()" onblur="blurHandler()"><option>abcd</option><option>efgh</option></select>
     </form>
     <pre id="console"></pre>