Changeset 210570 in webkit


Ignore:
Timestamp:
Jan 10, 2017 5:35:32 PM (7 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r210052.
​https://bugs.webkit.org/show_bug.cgi?id=166915

"breaks web compatability" (Requested by keith_miller on
#webkit).

Reverted changeset:

"Add support for global"
​https://bugs.webkit.org/show_bug.cgi?id=165171
​http://trac.webkit.org/changeset/210052

Location:
trunk
Files:
1 deleted
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/JSTests/ChangeLog

    r210563 r210570  
     12017-01-10  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r210052.
     4        https://bugs.webkit.org/show_bug.cgi?id=166915
     5
     6        "breaks web compatability" (Requested by keith_miller on
     7        #webkit).
     8
     9        Reverted changeset:
     10
     11        "Add support for global"
     12        https://bugs.webkit.org/show_bug.cgi?id=165171
     13        http://trac.webkit.org/changeset/210052
     14
    1152017-01-10  Mark Lam  <mark.lam@apple.com>
    216

  • trunk/LayoutTests/ChangeLog

    r210567 r210570  
     12017-01-10  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r210052.
     4        https://bugs.webkit.org/show_bug.cgi?id=166915
     5
     6        "breaks web compatability" (Requested by keith_miller on
     7        #webkit).
     8
     9        Reverted changeset:
     10
     11        "Add support for global"
     12        https://bugs.webkit.org/show_bug.cgi?id=165171
     13        http://trac.webkit.org/changeset/210052
     14
    1152017-01-10  Sam Weinig  <sam@webkit.org>
    216

  • trunk/LayoutTests/js/dom/getOwnPropertyDescriptor-expected.txt

    r210052 r210570  
    9595PASS Object.getOwnPropertyDescriptor(Math.sin, 'name').enumerable is false
    9696PASS Object.getOwnPropertyDescriptor(Math.sin, 'name').configurable is true
    97 PASS Object.getOwnPropertyDescriptor(globalObject, 'globalObject').value is globalObject
    98 PASS Object.getOwnPropertyDescriptor(globalObject, 'globalObject').hasOwnProperty('get') is false
    99 PASS Object.getOwnPropertyDescriptor(globalObject, 'globalObject').hasOwnProperty('set') is false
    100 PASS Object.getOwnPropertyDescriptor(globalObject, 'globalObject').enumerable is true
    101 PASS Object.getOwnPropertyDescriptor(globalObject, 'globalObject').configurable is false
    102 PASS Object.getOwnPropertyDescriptor(globalObject, 'undefined').value is undefined
    103 PASS Object.getOwnPropertyDescriptor(globalObject, 'undefined').hasOwnProperty('get') is false
    104 PASS Object.getOwnPropertyDescriptor(globalObject, 'undefined').hasOwnProperty('set') is false
    105 PASS Object.getOwnPropertyDescriptor(globalObject, 'undefined').enumerable is false
    106 PASS Object.getOwnPropertyDescriptor(globalObject, 'undefined').configurable is false
    107 PASS Object.getOwnPropertyDescriptor(globalObject, 'NaN').value is NaN
    108 PASS Object.getOwnPropertyDescriptor(globalObject, 'NaN').hasOwnProperty('get') is false
    109 PASS Object.getOwnPropertyDescriptor(globalObject, 'NaN').hasOwnProperty('set') is false
    110 PASS Object.getOwnPropertyDescriptor(globalObject, 'NaN').enumerable is false
    111 PASS Object.getOwnPropertyDescriptor(globalObject, 'NaN').configurable is false
    112 PASS Object.getOwnPropertyDescriptor(globalObject, 'Infinity').value is Infinity
    113 PASS Object.getOwnPropertyDescriptor(globalObject, 'Infinity').hasOwnProperty('get') is false
    114 PASS Object.getOwnPropertyDescriptor(globalObject, 'Infinity').hasOwnProperty('set') is false
    115 PASS Object.getOwnPropertyDescriptor(globalObject, 'Infinity').enumerable is false
    116 PASS Object.getOwnPropertyDescriptor(globalObject, 'Infinity').configurable is false
    117 PASS Object.getOwnPropertyDescriptor(globalObject, 'window').get is globalWindowGetter
    118 PASS Object.getOwnPropertyDescriptor(globalObject, 'window').set is undefined
    119 PASS Object.getOwnPropertyDescriptor(globalObject, 'window').hasOwnProperty('value') is false
    120 PASS Object.getOwnPropertyDescriptor(globalObject, 'window').hasOwnProperty('writable') is false
    121 PASS Object.getOwnPropertyDescriptor(globalObject, 'window').enumerable is true
    122 PASS Object.getOwnPropertyDescriptor(globalObject, 'window').configurable is false
    123 PASS Object.getOwnPropertyDescriptor(globalObject, 'XMLHttpRequest').value is XMLHttpRequest
    124 PASS Object.getOwnPropertyDescriptor(globalObject, 'XMLHttpRequest').hasOwnProperty('get') is false
    125 PASS Object.getOwnPropertyDescriptor(globalObject, 'XMLHttpRequest').hasOwnProperty('set') is false
    126 PASS Object.getOwnPropertyDescriptor(globalObject, 'XMLHttpRequest').enumerable is false
    127 PASS Object.getOwnPropertyDescriptor(globalObject, 'XMLHttpRequest').configurable is true
    128 PASS Object.getOwnPropertyDescriptor(globalObject, 0).value is globalObject[0]
    129 PASS Object.getOwnPropertyDescriptor(globalObject, 0).hasOwnProperty('get') is false
    130 PASS Object.getOwnPropertyDescriptor(globalObject, 0).hasOwnProperty('set') is false
    131 PASS Object.getOwnPropertyDescriptor(globalObject, 0).enumerable is false
    132 PASS Object.getOwnPropertyDescriptor(globalObject, 0).configurable is false
     97PASS Object.getOwnPropertyDescriptor(global, 'global').value is global
     98PASS Object.getOwnPropertyDescriptor(global, 'global').hasOwnProperty('get') is false
     99PASS Object.getOwnPropertyDescriptor(global, 'global').hasOwnProperty('set') is false
     100PASS Object.getOwnPropertyDescriptor(global, 'global').enumerable is true
     101PASS Object.getOwnPropertyDescriptor(global, 'global').configurable is false
     102PASS Object.getOwnPropertyDescriptor(global, 'undefined').value is undefined
     103PASS Object.getOwnPropertyDescriptor(global, 'undefined').hasOwnProperty('get') is false
     104PASS Object.getOwnPropertyDescriptor(global, 'undefined').hasOwnProperty('set') is false
     105PASS Object.getOwnPropertyDescriptor(global, 'undefined').enumerable is false
     106PASS Object.getOwnPropertyDescriptor(global, 'undefined').configurable is false
     107PASS Object.getOwnPropertyDescriptor(global, 'NaN').value is NaN
     108PASS Object.getOwnPropertyDescriptor(global, 'NaN').hasOwnProperty('get') is false
     109PASS Object.getOwnPropertyDescriptor(global, 'NaN').hasOwnProperty('set') is false
     110PASS Object.getOwnPropertyDescriptor(global, 'NaN').enumerable is false
     111PASS Object.getOwnPropertyDescriptor(global, 'NaN').configurable is false
     112PASS Object.getOwnPropertyDescriptor(global, 'Infinity').value is Infinity
     113PASS Object.getOwnPropertyDescriptor(global, 'Infinity').hasOwnProperty('get') is false
     114PASS Object.getOwnPropertyDescriptor(global, 'Infinity').hasOwnProperty('set') is false
     115PASS Object.getOwnPropertyDescriptor(global, 'Infinity').enumerable is false
     116PASS Object.getOwnPropertyDescriptor(global, 'Infinity').configurable is false
     117PASS Object.getOwnPropertyDescriptor(global, 'window').get is globalWindowGetter
     118PASS Object.getOwnPropertyDescriptor(global, 'window').set is undefined
     119PASS Object.getOwnPropertyDescriptor(global, 'window').hasOwnProperty('value') is false
     120PASS Object.getOwnPropertyDescriptor(global, 'window').hasOwnProperty('writable') is false
     121PASS Object.getOwnPropertyDescriptor(global, 'window').enumerable is true
     122PASS Object.getOwnPropertyDescriptor(global, 'window').configurable is false
     123PASS Object.getOwnPropertyDescriptor(global, 'XMLHttpRequest').value is XMLHttpRequest
     124PASS Object.getOwnPropertyDescriptor(global, 'XMLHttpRequest').hasOwnProperty('get') is false
     125PASS Object.getOwnPropertyDescriptor(global, 'XMLHttpRequest').hasOwnProperty('set') is false
     126PASS Object.getOwnPropertyDescriptor(global, 'XMLHttpRequest').enumerable is false
     127PASS Object.getOwnPropertyDescriptor(global, 'XMLHttpRequest').configurable is true
     128PASS Object.getOwnPropertyDescriptor(global, 0).value is global[0]
     129PASS Object.getOwnPropertyDescriptor(global, 0).hasOwnProperty('get') is false
     130PASS Object.getOwnPropertyDescriptor(global, 0).hasOwnProperty('set') is false
     131PASS Object.getOwnPropertyDescriptor(global, 0).enumerable is false
     132PASS Object.getOwnPropertyDescriptor(global, 0).configurable is false
    133133PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).value is document.getElementsByTagName('div')[0]
    134134PASS Object.getOwnPropertyDescriptor(document.getElementsByTagName('div'), 0).hasOwnProperty('get') is false

  • trunk/LayoutTests/js/resources/getOwnPropertyDescriptor.js

    r210052 r210570  
    3737descriptorShouldBe("Math.sin", "'length'", {writable: false, enumerable: false, configurable: true, value:1});
    3838descriptorShouldBe("Math.sin", "'name'", {writable: false, enumerable: false, configurable: true, value:"'sin'"});
    39 var globalObject = this;
    40 descriptorShouldBe("globalObject", "'globalObject'", {writable: true, enumerable: true, configurable: false, value:"globalObject"});
    41 descriptorShouldBe("globalObject", "'undefined'", {writable: false, enumerable: false, configurable: false, value:"undefined"});
    42 descriptorShouldBe("globalObject", "'NaN'", {writable: false, enumerable: false, configurable: false, value:"NaN"});
    43 descriptorShouldBe("globalObject", "'Infinity'", {writable: false, enumerable: false, configurable: false, value:"Infinity"});
    44 var globalWindowGetter = Object.getOwnPropertyDescriptor(globalObject, 'window').get;
    45 descriptorShouldBe("globalObject", "'window'", {get: 'globalWindowGetter', set: undefined, enumerable: true, configurable: false});
    46 descriptorShouldBe("globalObject", "'XMLHttpRequest'", {writable: true, enumerable: false, configurable: true, value:"XMLHttpRequest"});
    47 descriptorShouldBe("globalObject", "0", {writable: true, enumerable: false, configurable: false, value:"globalObject[0]"});
     39var global = this;
     40descriptorShouldBe("global", "'global'", {writable: true, enumerable: true, configurable: false, value:"global"});
     41descriptorShouldBe("global", "'undefined'", {writable: false, enumerable: false, configurable: false, value:"undefined"});
     42descriptorShouldBe("global", "'NaN'", {writable: false, enumerable: false, configurable: false, value:"NaN"});
     43descriptorShouldBe("global", "'Infinity'", {writable: false, enumerable: false, configurable: false, value:"Infinity"});
     44var globalWindowGetter = Object.getOwnPropertyDescriptor(global, 'window').get;
     45descriptorShouldBe("global", "'window'", {get: 'globalWindowGetter', set: undefined, enumerable: true, configurable: false});
     46descriptorShouldBe("global", "'XMLHttpRequest'", {writable: true, enumerable: false, configurable: true, value:"XMLHttpRequest"});
     47descriptorShouldBe("global", "0", {writable: true, enumerable: false, configurable: false, value:"global[0]"});
    4848descriptorShouldBe("document.getElementsByTagName('div')", "0", {writable: false, enumerable: true, configurable: true, value:"document.getElementsByTagName('div')[0]"});
    4949descriptorShouldBe("document.getElementsByClassName('pass')", "0", {writable: false, enumerable: true, configurable: true, value:"document.getElementsByClassName('pass')[0]"});

  • trunk/Source/JavaScriptCore/ChangeLog

    r210567 r210570  
     12017-01-10  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r210052.
     4        https://bugs.webkit.org/show_bug.cgi?id=166915
     5
     6        "breaks web compatability" (Requested by keith_miller on
     7        #webkit).
     8
     9        Reverted changeset:
     10
     11        "Add support for global"
     12        https://bugs.webkit.org/show_bug.cgi?id=165171
     13        http://trac.webkit.org/changeset/210052
     14
    1152017-01-10  Sam Weinig  <sam@webkit.org>
    216

  • trunk/Source/JavaScriptCore/runtime/JSGlobalObject.cpp

    r210522 r210570  
    273273  encodeURIComponent    globalFuncEncodeURIComponent                 DontEnum|Function 1
    274274  EvalError             JSGlobalObject::m_evalErrorConstructor       DontEnum|CellProperty
    275   global                JSGlobalObject::m_globalThis                 DontEnum|CellProperty
    276275  ReferenceError        JSGlobalObject::m_referenceErrorConstructor  DontEnum|CellProperty
    277276  SyntaxError           JSGlobalObject::m_syntaxErrorConstructor     DontEnum|CellProperty
Note: See TracChangeset for help on using the changeset viewer.