Changeset 210760 in webkit


Ignore:
Timestamp:
Jan 13, 2017 7:42:32 PM (7 years ago)
Author:
Brent Fulgham
Message:

Potential nullptr dereference in RenderLayer::updateLayerPosition()
https://bugs.webkit.org/show_bug.cgi?id=167036
<rdar://problem/30023019>

Reviewed by Dean Jackson.

A value was being used without nullptr checking, even though it had been checked for null a
few lines prior.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition): Add missing nullptr check.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r210758 r210760  
     12017-01-13  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Potential nullptr dereference in RenderLayer::updateLayerPosition()
     4        https://bugs.webkit.org/show_bug.cgi?id=167036
     5        <rdar://problem/30023019>
     6
     7        Reviewed by Dean Jackson.
     8
     9        A value was being used without nullptr checking, even though it had been checked for null a
     10        few lines prior.
     11
     12        * rendering/RenderLayer.cpp:
     13        (WebCore::RenderLayer::updateLayerPosition): Add missing nullptr check.
     14
    1152017-01-11  Darin Adler  <darin@apple.com>
    216
  • trunk/Source/WebCore/rendering/RenderLayer.cpp

    r210758 r210760  
    13611361            ancestor = ancestor->parent();
    13621362        }
    1363         if (is<RenderBox>(*ancestor) && is<RenderTableRow>(*ancestor)) {
     1363        if (ancestor && is<RenderBox>(*ancestor) && is<RenderTableRow>(*ancestor)) {
    13641364            // Put ourselves into the row coordinate space.
    13651365            localPoint -= downcast<RenderBox>(*ancestor).topLeftLocationOffset();
Note: See TracChangeset for help on using the changeset viewer.