Changeset 210855 in webkit

Timestamp:

Jan 18, 2017 10:45:59 AM (7 years ago)

Author:

pvollan@apple.com

Message:

Crash when changing video subtitles.
​https://bugs.webkit.org/show_bug.cgi?id=167159

Reviewed by Xabier Rodriguez-Calvar.

Add null pointer check.

• html/track/VTTCue.cpp:

(WebCore::VTTCue::removeDisplayTree):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/track/VTTCue.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-01-18  Per Arne Vollan  <pvollan@apple.com>
+
+        Crash when changing video subtitles.
+        https://bugs.webkit.org/show_bug.cgi?id=167159
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Add null pointer check.
+
+        * html/track/VTTCue.cpp:
+        (WebCore::VTTCue::removeDisplayTree):
+
 2017-01-18  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/html/track/VTTCue.cpp

@@ -839 +839 @@
         if (VTTRegionList* regions = track()->regions()) {
             if (VTTRegion* region = regions->getRegionById(m_regionId))
-                region->willRemoveTextTrackCueBox(m_displayTree.get());
+                if (hasDisplayTree())
+                    region->willRemoveTextTrackCueBox(m_displayTree.get());
         }
     }