Changeset 210881 in webkit


Ignore:
Timestamp:
Jan 18, 2017 1:26:07 PM (7 years ago)
Author:
yoav@yoav.ws
Message:

REGRESSION(r203110): LayoutTest http/tests/preload/single_download_preload_runner.html timing out
https://bugs.webkit.org/show_bug.cgi?id=159678

Move the single_download_preload test to be in a single document rather than a frame, as the frame based version was timing out.
I suspect that recent changes to handling of feature flags resulted in feature flags turned off for frames, which caused this test
to fail. As the frame doesn't seem required in this case, we can fold the entire test to a single document.
On top of that, I added per resource verification for the number of requests, which makes the test clearer.

Reviewed by Alex Christensen.

  • TestExpectations: Removed the timeout expectation for the test.
  • http/tests/preload/single_download_preload-expected.txt: Renamed from LayoutTests/http/tests/preload/single_download_preload_runner-expected.txt.
  • http/tests/preload/single_download_preload.html: Renamed from LayoutTests/http/tests/preload/resources/single_download_preload.html as well as fixed.
  • http/tests/preload/single_download_preload_runner.html: Removed.
  • http/tests/resources/dummy.xml: Added.
  • http/tests/resources/test.oga: Added.
  • platform/mac/TestExpectations: Removed the timeout expectation for the test.
Location:
trunk/LayoutTests
Files:
3 added
2 deleted
3 edited
1 moved

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r210864 r210881  
     12017-01-18  Yoav Weiss  <yoav@yoav.ws>
     2
     3        REGRESSION(r203110): LayoutTest http/tests/preload/single_download_preload_runner.html timing out
     4        https://bugs.webkit.org/show_bug.cgi?id=159678
     5
     6        Move the single_download_preload test to be in a single document rather than a frame, as the frame based version was timing out.
     7        I suspect that recent changes to handling of feature flags resulted in feature flags turned off for frames, which caused this test
     8        to fail. As the frame doesn't seem required in this case, we can fold the entire test to a single document.
     9        On top of that, I added per resource verification for the number of requests, which makes the test clearer.
     10
     11        Reviewed by Alex Christensen.
     12
     13        * TestExpectations: Removed the timeout expectation for the test.
     14        * http/tests/preload/single_download_preload-expected.txt: Renamed from LayoutTests/http/tests/preload/single_download_preload_runner-expected.txt.
     15        * http/tests/preload/single_download_preload.html: Renamed from LayoutTests/http/tests/preload/resources/single_download_preload.html as well as fixed.
     16        * http/tests/preload/single_download_preload_runner.html: Removed.
     17        * http/tests/resources/dummy.xml: Added.
     18        * http/tests/resources/test.oga: Added.
     19        * platform/mac/TestExpectations: Removed the timeout expectation for the test.
     20
    1212017-01-18  Andy Estes  <aestes@apple.com>
    222
  • trunk/LayoutTests/TestExpectations

    r210860 r210881  
    909909webkit.org/b/159370 [ Debug ] fast/history/page-cache-destroy-document.html [ Skip ]
    910910
    911 webkit.org/b/159678 http/tests/preload/single_download_preload_runner.html [ Timeout ]
    912 
    913911# This test is way too slow for debug.
    914912[ Debug ] workers/bomb.html [ Skip ]
  • trunk/LayoutTests/http/tests/preload/single_download_preload-expected.txt

    r210880 r210881  
    1 CONSOLE MESSAGE: line 10: <link rel=preload> must have a valid `as` value
    2 
     1CONSOLE MESSAGE: line 21: <link rel=preload> must have a valid `as` value
     2 
    33
    44PASS Makes sure that preloaded resources are not downloaded again when used
  • trunk/LayoutTests/platform/mac/TestExpectations

    r210848 r210881  
    13561356[ Sierra+ ] http/tests/security/contentSecurityPolicy/video-redirect-allowed2.html [ Skip ]
    13571357
    1358 # <rdar://problem/26590623> LayoutTest http/tests/preload/single_download_preload_runner.html failing
    1359 [ Sierra+ ] http/tests/preload/single_download_preload_runner.html [ Pass Timeout Failure ]
    1360 
    13611358# rdar://problem/26952627
    13621359[ Sierra+ ] css3/filters/backdrop/backdrop-filter-with-border-radius-and-reflection-add.html [ Pass ImageOnlyFailure ]
Note: See TracChangeset for help on using the changeset viewer.