Changeset 211168 in webkit


Ignore:
Timestamp:
Jan 25, 2017 2:44:15 PM (7 years ago)
Author:
Chris Dumez
Message:

Disable Download attribute support on iOS
​https://bugs.webkit.org/show_bug.cgi?id=167337
<rdar://problem/30154148>

Reviewed by Alexey Proskuryakov.

Disable Download attribute support on iOS as it currently does not work.

  • wtf/FeatureDefines.h:
Location:
trunk
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt

    r210823 r211168  
    65236523PASS area.target: IDL set to object "test-toString"
    65246524PASS area.target: IDL set to object "test-valueOf"
    6525 PASS area.download: typeof IDL attribute
    6526 PASS area.download: IDL get with DOM attribute unset
    6527 PASS area.download: setAttribute() to ""
    6528 PASS area.download: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo "
    6529 PASS area.download: setAttribute() to undefined
    6530 PASS area.download: setAttribute() to 7
    6531 PASS area.download: setAttribute() to 1.5
    6532 PASS area.download: setAttribute() to true
    6533 PASS area.download: setAttribute() to false
    6534 PASS area.download: setAttribute() to object "[object Object]"
    6535 PASS area.download: setAttribute() to NaN
    6536 PASS area.download: setAttribute() to Infinity
    6537 PASS area.download: setAttribute() to -Infinity
    6538 PASS area.download: setAttribute() to "\0"
    6539 PASS area.download: setAttribute() to null
    6540 PASS area.download: setAttribute() to object "test-toString"
    6541 PASS area.download: setAttribute() to object "test-valueOf"
    6542 PASS area.download: IDL set to ""
    6543 PASS area.download: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo "
    6544 PASS area.download: IDL set to undefined
    6545 PASS area.download: IDL set to 7
    6546 PASS area.download: IDL set to 1.5
    6547 PASS area.download: IDL set to true
    6548 PASS area.download: IDL set to false
    6549 PASS area.download: IDL set to object "[object Object]"
    6550 PASS area.download: IDL set to NaN
    6551 PASS area.download: IDL set to Infinity
    6552 PASS area.download: IDL set to -Infinity
    6553 PASS area.download: IDL set to "\0"
    6554 PASS area.download: IDL set to null
    6555 PASS area.download: IDL set to object "test-toString"
    6556 PASS area.download: IDL set to object "test-valueOf"
     6525FAIL area.download: typeof IDL attribute assert_equals: expected "string" but got "undefined"
     6526FAIL area.download: IDL get with DOM attribute unset assert_equals: expected (string) "" but got (undefined) undefined
     6527FAIL area.download: setAttribute() to "" assert_equals: IDL get expected (string) "" but got (undefined) undefined
     6528FAIL area.download: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " assert_equals: IDL get expected (string) " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " but got (undefined) undefined
     6529FAIL area.download: setAttribute() to undefined assert_equals: IDL get expected (string) "undefined" but got (undefined) undefined
     6530FAIL area.download: setAttribute() to 7 assert_equals: IDL get expected (string) "7" but got (undefined) undefined
     6531FAIL area.download: setAttribute() to 1.5 assert_equals: IDL get expected (string) "1.5" but got (undefined) undefined
     6532FAIL area.download: setAttribute() to true assert_equals: IDL get expected (string) "true" but got (undefined) undefined
     6533FAIL area.download: setAttribute() to false assert_equals: IDL get expected (string) "false" but got (undefined) undefined
     6534FAIL area.download: setAttribute() to object "[object Object]" assert_equals: IDL get expected (string) "[object Object]" but got (undefined) undefined
     6535FAIL area.download: setAttribute() to NaN assert_equals: IDL get expected (string) "NaN" but got (undefined) undefined
     6536FAIL area.download: setAttribute() to Infinity assert_equals: IDL get expected (string) "Infinity" but got (undefined) undefined
     6537FAIL area.download: setAttribute() to -Infinity assert_equals: IDL get expected (string) "-Infinity" but got (undefined) undefined
     6538FAIL area.download: setAttribute() to "\0" assert_equals: IDL get expected (string) "\0" but got (undefined) undefined
     6539FAIL area.download: setAttribute() to null assert_equals: IDL get expected (string) "null" but got (undefined) undefined
     6540FAIL area.download: setAttribute() to object "test-toString" assert_equals: IDL get expected (string) "test-toString" but got (undefined) undefined
     6541FAIL area.download: setAttribute() to object "test-valueOf" assert_equals: IDL get expected (string) "test-valueOf" but got (undefined) undefined
     6542FAIL area.download: IDL set to "" assert_equals: getAttribute() expected "" but got "test-valueOf"
     6543FAIL area.download: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " assert_equals: getAttribute() expected " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " but got "test-valueOf"
     6544FAIL area.download: IDL set to undefined assert_equals: getAttribute() expected "undefined" but got "test-valueOf"
     6545FAIL area.download: IDL set to 7 assert_equals: getAttribute() expected "7" but got "test-valueOf"
     6546FAIL area.download: IDL set to 1.5 assert_equals: getAttribute() expected "1.5" but got "test-valueOf"
     6547FAIL area.download: IDL set to true assert_equals: getAttribute() expected "true" but got "test-valueOf"
     6548FAIL area.download: IDL set to false assert_equals: getAttribute() expected "false" but got "test-valueOf"
     6549FAIL area.download: IDL set to object "[object Object]" assert_equals: getAttribute() expected "[object Object]" but got "test-valueOf"
     6550FAIL area.download: IDL set to NaN assert_equals: getAttribute() expected "NaN" but got "test-valueOf"
     6551FAIL area.download: IDL set to Infinity assert_equals: getAttribute() expected "Infinity" but got "test-valueOf"
     6552FAIL area.download: IDL set to -Infinity assert_equals: getAttribute() expected "-Infinity" but got "test-valueOf"
     6553FAIL area.download: IDL set to "\0" assert_equals: getAttribute() expected "\0" but got "test-valueOf"
     6554FAIL area.download: IDL set to null assert_equals: getAttribute() expected "null" but got "test-valueOf"
     6555FAIL area.download: IDL set to object "test-toString" assert_equals: getAttribute() expected "test-toString" but got "test-valueOf"
     6556FAIL area.download: IDL set to object "test-valueOf" assert_equals: IDL get expected (string) "test-valueOf" but got (object) object "test-valueOf"
    65576557PASS area.ping: typeof IDL attribute
    65586558PASS area.ping: IDL get with DOM attribute unset

  • trunk/Source/WTF/ChangeLog

    r211150 r211168  
     12017-01-25  Chris Dumez  <cdumez@apple.com>
     2
     3        Disable Download attribute support on iOS
     4        https://bugs.webkit.org/show_bug.cgi?id=167337
     5        <rdar://problem/30154148>
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        Disable Download attribute support on iOS as it currently does not work.
     10
     11        * wtf/FeatureDefines.h:
     12
    1132017-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
    214

  • trunk/Source/WTF/wtf/FeatureDefines.h

    r211133 r211168  
    165165#endif
    166166
     167#if !defined(ENABLE_DOWNLOAD_ATTRIBUTE)
     168#define ENABLE_DOWNLOAD_ATTRIBUTE 0
     169#endif
     170
    167171#endif /* PLATFORM(IOS) */
    168172
Note: See TracChangeset for help on using the changeset viewer.