Changeset 211169 in webkit


Ignore:
Timestamp:
Jan 25, 2017 2:51:54 PM (7 years ago)
Author:
yoav@yoav.ws
Message:

REGRESSION(r203110): LayoutTest http/tests/preload/single_download_preload_runner.html timing out
https://bugs.webkit.org/show_bug.cgi?id=159678

Move the single_download_preload test to be in a single document rather than a frame, as the frame based version was timing out.
I suspect that recent changes to handling of feature flags resulted in feature flags turned off for frames, which caused this test
to fail. As the frame doesn't seem required in this case, we can fold the entire test to a single document.
On top of that, I added per resource verification for the number of requests, which makes the test clearer, and avoided verifying
result for resource types that are currently failing/flaky.

Reviewed by Alex Christensen

  • TestExpectations: Removed the timeout expectation for the test.
  • http/tests/preload/single_download_preload-expected.txt: Renamed from LayoutTests/http/tests/preload/single_download_preload_runner-expected.txt.
  • http/tests/preload/single_download_preload.html: Renamed from LayoutTests/http/tests/preload/resources/single_download_preload.html as well as fixed.
  • http/tests/preload/single_download_preload_runner.html: Removed.
  • http/tests/resources/dummy.xml: Added.
  • http/tests/resources/test.oga: Added.
  • platform/mac/TestExpectations: Removed the timeout expectation for the test.
Location:
trunk/LayoutTests
Files:
3 added
2 deleted
3 edited
1 moved

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r211166 r211169  
     12017-01-25  Yoav Weiss  <yoav@yoav.ws>
     2
     3        REGRESSION(r203110): LayoutTest http/tests/preload/single_download_preload_runner.html timing out
     4        https://bugs.webkit.org/show_bug.cgi?id=159678
     5
     6        Move the single_download_preload test to be in a single document rather than a frame, as the frame based version was timing out.
     7        I suspect that recent changes to handling of feature flags resulted in feature flags turned off for frames, which caused this test
     8        to fail. As the frame doesn't seem required in this case, we can fold the entire test to a single document.
     9        On top of that, I added per resource verification for the number of requests, which makes the test clearer, and avoided verifying
     10        result for resource types that are currently failing/flaky.
     11
     12        Reviewed by Alex Christensen
     13
     14        * TestExpectations: Removed the timeout expectation for the test.
     15        * http/tests/preload/single_download_preload-expected.txt: Renamed from LayoutTests/http/tests/preload/single_download_preload_runner-expected.txt.
     16        * http/tests/preload/single_download_preload.html: Renamed from LayoutTests/http/tests/preload/resources/single_download_preload.html as well as fixed.
     17        * http/tests/preload/single_download_preload_runner.html: Removed.
     18        * http/tests/resources/dummy.xml: Added.
     19        * http/tests/resources/test.oga: Added.
     20        * platform/mac/TestExpectations: Removed the timeout expectation for the test.
     21
    1222017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
    223
  • trunk/LayoutTests/TestExpectations

    r211166 r211169  
    910910webkit.org/b/159370 [ Debug ] fast/history/page-cache-destroy-document.html [ Skip ]
    911911
    912 webkit.org/b/159678 http/tests/preload/single_download_preload_runner.html [ Timeout ]
    913 
    914912# This test is way too slow for debug.
    915913[ Debug ] workers/bomb.html [ Skip ]
  • trunk/LayoutTests/http/tests/preload/single_download_preload-expected.txt

    r211168 r211169  
    1 CONSOLE MESSAGE: line 10: <link rel=preload> must have a valid `as` value
    2 
     1CONSOLE MESSAGE: line 21: <link rel=preload> must have a valid `as` value
     2 
    33
    44PASS Makes sure that preloaded resources are not downloaded again when used
  • trunk/LayoutTests/platform/mac/TestExpectations

    r211157 r211169  
    13571357[ Sierra+ ] http/tests/security/contentSecurityPolicy/video-redirect-allowed2.html [ Skip ]
    13581358
    1359 # <rdar://problem/26590623> LayoutTest http/tests/preload/single_download_preload_runner.html failing
    1360 [ Sierra+ ] http/tests/preload/single_download_preload_runner.html [ Pass Timeout Failure ]
    1361 
    13621359# rdar://problem/26952627
    13631360[ Sierra+ ] css3/filters/backdrop/backdrop-filter-with-border-radius-and-reflection-add.html [ Pass ImageOnlyFailure ]
Note: See TracChangeset for help on using the changeset viewer.