Changeset 211234 in webkit

Timestamp:

Jan 26, 2017 3:47:06 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Request pointer unlock on navigation and re-enable pointer-lock tests for WK2.
​https://bugs.webkit.org/show_bug.cgi?id=166765

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-01-26
Reviewed by Tim Horton.

Source/WebKit2:

When the main frame is load is committed, pointer lock should end.
This resets pointer lock state between tests and allows tests to succeed.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

LayoutTests:

Enabled pointer lock tests for wk2 now that pointer lock state is being reset after each test.

• platform/mac-wk2/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac-wk2/TestExpectations (modified) (1 diff)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/UIProcess/WebPageProxy.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-01-26  Jeremy Jones  <jeremyj@apple.com>
+
+        Request pointer unlock on navigation and re-enable pointer-lock tests for WK2.
+        https://bugs.webkit.org/show_bug.cgi?id=166765
+
+        Reviewed by Tim Horton.
+
+        Enabled pointer lock tests for wk2 now that pointer lock state is being reset after each test.
+
+        * platform/mac-wk2/TestExpectations:
+
 2017-01-26  Zalan Bujtas  <zalan@apple.com>
 

trunk/LayoutTests/platform/mac-wk2/TestExpectations

@@ -602 +602 @@
 webkit.org/b/165392 [ ElCapitan Release ] imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html [ Pass Failure ]
 
-webkit.org/b/166765 pointer-lock/ [ Skip ]
-webkit.org/b/166765 http/tests/pointer-lock/ [ Skip ]
-
 webkit.org/b/161887 [ ElCapitan ] swipe/main-frame-pinning-requirement.html [ Pass Timeout ]

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2017-01-26  Jeremy Jones  <jeremyj@apple.com>
+
+        Request pointer unlock on navigation and re-enable pointer-lock tests for WK2.
+        https://bugs.webkit.org/show_bug.cgi?id=166765
+
+        Reviewed by Tim Horton.
+
+        When the main frame is load is committed, pointer lock should end.
+        This resets pointer lock state between tests and allows tests to succeed.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::didCommitLoadForFrame):
+
 2017-01-26  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -3354 +3354 @@
     }
 
+#if ENABLE(POINTER_LOCK)
+    if (frame->isMainFrame())
+        requestPointerUnlock();
+#endif
+
     m_pageLoadState.commitChanges();
     if (m_navigationClient) {