Changeset 211291 in webkit
- Timestamp:
- Jan 27, 2017 11:14:57 AM (7 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r211289 r211291 1 2017-01-27 Chris Dumez <cdumez@apple.com> 2 3 Fix PageCache diagnostic logging 4 https://bugs.webkit.org/show_bug.cgi?id=167508 5 6 Reviewed by Sam Weinig. 7 8 Fix PageCache diagnostic logging. It should not call logDiagnosticMessageWithValue() 9 with a non-numeric value. Use logDiagnosticMessage() instead. 10 11 * history/PageCache.cpp: 12 (WebCore::logPageCacheFailureDiagnosticMessage): 13 (WebCore::canCacheFrame): 14 * page/DiagnosticLoggingKeys.cpp: 15 (WebCore::DiagnosticLoggingKeys::pageCacheFailureKey): 16 (WebCore::DiagnosticLoggingKeys::successKey): Deleted. 17 (WebCore::DiagnosticLoggingKeys::failureKey): Deleted. 18 * page/DiagnosticLoggingKeys.h: 19 1 20 2017-01-27 Devin Rousso <dcrousso+webkit@gmail.com> 2 21 -
trunk/Source/WebCore/history/PageCache.cpp
r211254 r211291 65 65 static inline void logPageCacheFailureDiagnosticMessage(DiagnosticLoggingClient& client, const String& reason) 66 66 { 67 client.logDiagnosticMessage WithValue(DiagnosticLoggingKeys::pageCacheKey(), DiagnosticLoggingKeys::failureKey(), reason, ShouldSample::Yes);67 client.logDiagnosticMessage(DiagnosticLoggingKeys::pageCacheFailureKey(), reason, ShouldSample::Yes); 68 68 } 69 69 … … 155 155 for (auto* activeDOMObject : unsuspendableObjects) { 156 156 PCLOG(" - Unsuspendable: ", activeDOMObject->activeDOMObjectName()); 157 diagnosticLoggingClient.logDiagnosticMessage WithValue(DiagnosticLoggingKeys::pageCacheKey(),DiagnosticLoggingKeys::unsuspendableDOMObjectKey(), activeDOMObject->activeDOMObjectName(), ShouldSample::Yes);157 diagnosticLoggingClient.logDiagnosticMessage(DiagnosticLoggingKeys::unsuspendableDOMObjectKey(), activeDOMObject->activeDOMObjectName(), ShouldSample::Yes); 158 158 UNUSED_PARAM(activeDOMObject); 159 159 } -
trunk/Source/WebCore/page/DiagnosticLoggingKeys.cpp
r211254 r211291 104 104 } 105 105 106 String DiagnosticLoggingKeys::successKey()107 {108 return ASCIILiteral("success");109 }110 111 String DiagnosticLoggingKeys::failureKey()112 {113 return ASCIILiteral("failure");114 }115 116 106 String DiagnosticLoggingKeys::pageLoadedKey() 117 107 { … … 197 187 { 198 188 return ASCIILiteral("pageCache"); 189 } 190 191 String DiagnosticLoggingKeys::pageCacheFailureKey() 192 { 193 return ASCIILiteral("pageCacheFailure"); 199 194 } 200 195 -
trunk/Source/WebCore/page/DiagnosticLoggingKeys.h
r211254 r211291 98 98 WEBCORE_EXPORT static String otherKey(); 99 99 static String pageCacheKey(); 100 static String pageCacheFailureKey(); 100 101 static String pageContainsAtLeastOneMediaEngineKey(); 101 102 static String pageContainsAtLeastOnePluginKey(); … … 169 170 WEBCORE_EXPORT static String foregroundCPUUsageToDiagnosticLoggingKey(double cpuUsage); 170 171 WEBCORE_EXPORT static String backgroundCPUUsageToDiagnosticLoggingKey(double cpuUsage); 171 172 // Success / Failure keys.173 static String successKey();174 static String failureKey();175 172 }; 176 173
Note: See TracChangeset
for help on using the changeset viewer.