Changeset 211315 in webkit


Ignore:
Timestamp:
Jan 27, 2017 4:55:39 PM (7 years ago)
Author:
keith_miller@apple.com
Message:

run-benchmarks should make sure it passes the test url to the right application
​https://bugs.webkit.org/show_bug.cgi?id=167533

Reviewed by Joseph Pecoraro.

This fixes an issue when trying to run-benchmark script with the
system default browser set to STP. Previously, it would run
the test in STP rather than the provided build. Now, it should run
in the provided build.

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:

(OSXSafariDriver.launch_url):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r211308 r211315  
     12017-01-27  Keith Miller  <keith_miller@apple.com>
     2
     3        run-benchmarks should make sure it passes the test url to the right application
     4        https://bugs.webkit.org/show_bug.cgi?id=167533
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        This fixes an issue when trying to run-benchmark script with the
     9        system default browser set to STP. Previously, it would run
     10        the test in STP rather than the provided build. Now, it should run
     11        in the provided build.
     12
     13        * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
     14        (OSXSafariDriver.launch_url):
     15
    1162017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
    217

  • trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py

    r199805 r211315  
    4444        # command may use the system safari.
    4545        time.sleep(3)
    46         subprocess.Popen(['open', url])
     46        subprocess.Popen(['open', '-a', args[0], url])
    4747
    4848    def close_browsers(self):
Note: See TracChangeset for help on using the changeset viewer.