Changeset 211386 in webkit

Timestamp:

Jan 30, 2017 2:09:01 PM (7 years ago)

Author:

jer.noble@apple.com

Message:

NULL-deref crash at PlatformMediaSession::endInterruption
​https://bugs.webkit.org/show_bug.cgi?id=167595

Reviewed by Eric Carlson.

Use the same, NULL-aware forEachSession() iterator rather than iterating over m_sessions directly.

• platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::beginInterruption):
(WebCore::PlatformMediaSessionManager::endInterruption):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/audio/PlatformMediaSessionManager.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-01-30  Jer Noble  <jer.noble@apple.com>
+
+        NULL-deref crash at PlatformMediaSession::endInterruption
+        https://bugs.webkit.org/show_bug.cgi?id=167595
+
+        Reviewed by Eric Carlson.
+
+        Use the same, NULL-aware forEachSession() iterator rather than iterating over m_sessions directly.
+
+        * platform/audio/PlatformMediaSessionManager.cpp:
+        (WebCore::PlatformMediaSessionManager::beginInterruption):
+        (WebCore::PlatformMediaSessionManager::endInterruption):
+
 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp

@@ -113 +113 @@
 
     m_interrupted = true;
-    Vector<PlatformMediaSession*> sessions = m_sessions;
-    for (auto* session : sessions)
-        session->beginInterruption(type);
+    forEachSession([type] (PlatformMediaSession& session, size_t) {
+        session.beginInterruption(type);
+    });
     updateSessionState();
 }
@@ -124 +124 @@
 
     m_interrupted = false;
-    Vector<PlatformMediaSession*> sessions = m_sessions;
-    for (auto* session : sessions)
-        session->endInterruption(flags);
+    forEachSession([flags] (PlatformMediaSession& session, size_t) {
+        session.endInterruption(flags);
+    });
 }