Changeset 211395 in webkit


Ignore:
Timestamp:
Jan 30, 2017 4:22:27 PM (7 years ago)
Author:
Chris Dumez
Message:

Drop legacy Attributes.isId attribute
​https://bugs.webkit.org/show_bug.cgi?id=167603

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that one more check is passing.

  • web-platform-tests/dom/historical-expected.txt:

Source/WebCore:

Drop legacy Attributes.isId attribute.

This attribute is not in the specification:

Both Firefox and Chrome currently do not expose this attribute.

No new tests, rebaselined existing test.

  • dom/Attr.cpp:
  • dom/Attr.h:
  • dom/Attr.idl:

Source/WebKit/mac:

Keep Attr.isId in ObjC bindings.

  • DOM/DOMAttr.mm:

(-[DOMAttr isId]):

LayoutTests:

Drop outdated tests.

  • dom/xhtml/level3/core/attrisid04-expected.txt: Removed.
  • dom/xhtml/level3/core/attrisid04.xhtml: Removed.
  • dom/xhtml/level3/core/attrisid05-expected.txt: Removed.
  • dom/xhtml/level3/core/attrisid05.xhtml: Removed.
  • fast/dom/Attr/change-id-via-attr-node-value-expected.txt:
  • fast/dom/Attr/change-id-via-attr-node-value.html:
  • fast/dom/Element/attrisid-extra01-expected.txt: Removed.
  • fast/dom/Element/attrisid-extra01.html: Removed.
Location:
trunk
Files:
6 deleted
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r211393 r211395  
     12017-01-30  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop legacy Attributes.isId attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=167603
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Drop outdated tests.
     9
     10        * dom/xhtml/level3/core/attrisid04-expected.txt: Removed.
     11        * dom/xhtml/level3/core/attrisid04.xhtml: Removed.
     12        * dom/xhtml/level3/core/attrisid05-expected.txt: Removed.
     13        * dom/xhtml/level3/core/attrisid05.xhtml: Removed.
     14        * fast/dom/Attr/change-id-via-attr-node-value-expected.txt:
     15        * fast/dom/Attr/change-id-via-attr-node-value.html:
     16        * fast/dom/Element/attrisid-extra01-expected.txt: Removed.
     17        * fast/dom/Element/attrisid-extra01.html: Removed.
     18
    1192017-01-30  Chris Dumez  <cdumez@apple.com>
    220

  • trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value-expected.txt

    r204236 r211395  
    88PASS document.getElementById("a") is document.body
    99PASS document.body.id is "a"
    10 PASS document.body.getAttributeNode("id").isId is true
    1110PASS document.body.getAttributeNode("id").textContent is "a"
    1211

  • trunk/LayoutTests/fast/dom/Attr/change-id-via-attr-node-value.html

    r204236 r211395  
    1212shouldBe('document.getElementById("a")', 'document.body');
    1313shouldBe('document.body.id', '"a"');
    14 shouldBe('document.body.getAttributeNode("id").isId', 'true');
    1514shouldBe('document.body.getAttributeNode("id").textContent', '"a"');
    1615

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r211393 r211395  
     12017-01-30  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop legacy Attributes.isId attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=167603
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Rebaseline W3C test now that one more check is passing.
     9
     10        * web-platform-tests/dom/historical-expected.txt:
     11
    1122017-01-30  Chris Dumez  <cdumez@apple.com>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt

    r211393 r211395  
    3838PASS Historical DOM features must be removed: setIdAttributeNode
    3939PASS Attr member must be nuked: schemaTypeInfo
    40 FAIL Attr member must be nuked: isId assert_equals: expected (undefined) undefined but got (boolean) false
     40PASS Attr member must be nuked: isId
    4141PASS DocumentType member must be nuked: entities
    4242PASS DocumentType member must be nuked: notations

  • trunk/Source/WebCore/ChangeLog

    r211394 r211395  
     12017-01-30  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop legacy Attributes.isId attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=167603
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Drop legacy Attributes.isId attribute.
     9
     10        This attribute is not in the specification:
     11        - https://dom.spec.whatwg.org/#interface-attr
     12
     13        Both Firefox and Chrome currently do not expose this attribute.
     14
     15        No new tests, rebaselined existing test.
     16
     17        * dom/Attr.cpp:
     18        * dom/Attr.h:
     19        * dom/Attr.idl:
     20
    1212017-01-30  Zalan Bujtas  <zalan@apple.com>
    222

  • trunk/Source/WebCore/dom/Attr.cpp

    r208603 r211395  
    172172}
    173173
    174 bool Attr::isId() const
    175 {
    176     return qualifiedName().matches(HTMLNames::idAttr);
    177 }
    178 
    179174CSSStyleDeclaration* Attr::style()
    180175{

  • trunk/Source/WebCore/dom/Attr.h

    r208603 r211395  
    5757    const QualifiedName& qualifiedName() const { return m_name; }
    5858
    59     WEBCORE_EXPORT bool isId() const;
    60 
    6159    WEBCORE_EXPORT CSSStyleDeclaration* style();
    6260

  • trunk/Source/WebCore/dom/Attr.idl

    r207170 r211395  
    3232    readonly attribute Element ownerElement;
    3333
    34     readonly attribute boolean isId;
    35 
    3634    readonly attribute DOMString? namespaceURI;
    3735    readonly attribute DOMString? prefix;

  • trunk/Source/WebKit/mac/ChangeLog

    r211362 r211395  
     12017-01-30  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop legacy Attributes.isId attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=167603
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Keep Attr.isId in ObjC bindings.
     9
     10        * DOM/DOMAttr.mm:
     11        (-[DOMAttr isId]):
     12
    1132017-01-30  Andreas Kling  <akling@apple.com>
    214

  • trunk/Source/WebKit/mac/DOM/DOMAttr.mm

    r204717 r211395  
    7777{
    7878    WebCore::JSMainThreadNullState state;
    79     return IMPL->isId();
     79    return IMPL->qualifiedName().matches(WebCore::HTMLNames::idAttr);
    8080}
    8181
Note: See TracChangeset for help on using the changeset viewer.