Changeset 211408 in webkit


Ignore:
Timestamp:
Jan 30, 2017 11:11:45 PM (7 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: "bouncy highlight" element in TextEditor/DOMTreeOutline should update or dismiss when user scrolls
https://bugs.webkit.org/show_bug.cgi?id=167146

Patch by Devin Rousso <Devin Rousso> on 2017-01-30
Reviewed by Timothy Hatcher.

  • UserInterface/Views/TextEditor.js:

(WebInspector.TextEditor.prototype._revealSearchResult.scrollHandler):
(WebInspector.TextEditor.prototype._revealSearchResult.animationEnded):
(WebInspector.TextEditor.prototype._revealSearchResult):

Location:
trunk/Source/WebInspectorUI
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r211406 r211408  
     12017-01-30  Devin Rousso  <dcrousso+webkit@gmail.com>
     2
     3        Web Inspector: "bouncy highlight" element in TextEditor/DOMTreeOutline should update or dismiss when user scrolls
     4        https://bugs.webkit.org/show_bug.cgi?id=167146
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        * UserInterface/Views/TextEditor.js:
     9        (WebInspector.TextEditor.prototype._revealSearchResult.scrollHandler):
     10        (WebInspector.TextEditor.prototype._revealSearchResult.animationEnded):
     11        (WebInspector.TextEditor.prototype._revealSearchResult):
     12
    1132017-01-30  Joseph Pecoraro  <pecoraro@apple.com>
    214
  • trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js

    r209492 r211408  
    10871087        this.element.appendChild(this._bouncyHighlightElement);
    10881088
     1089        let scrollHandler = () => {
     1090            if (this._bouncyHighlightElement)
     1091                this._bouncyHighlightElement.remove();
     1092        };
     1093
     1094        this.addScrollHandler(scrollHandler);
     1095
    10891096        function animationEnded()
    10901097        {
     
    10941101            this._bouncyHighlightElement.remove();
    10951102            delete this._bouncyHighlightElement;
     1103
     1104            this.removeScrollHandler(scrollHandler);
    10961105        }
    10971106
Note: See TracChangeset for help on using the changeset viewer.