Changeset 21143 in webkit

Timestamp:

Apr 27, 2007 1:43:19 AM (17 years ago)

Author:

mjs

Message:

Reviewed by Mark.

<rdar://problem/5154113> Repro ASSERT (would be crash) in KJS::GCLock::GCLock (13462)
​http://bugs.webkit.org/show_bug.cgi?id=13462

• WebInspector/WebInspector.m: (-[WebInspectorPrivate dealloc]): Delay release of WebView to avoid GC re-entrancy.

Location:

trunk/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebInspector/WebInspector.m (modified) (1 diff)

trunk/WebKit/ChangeLog

@@ +1 @@
+2007-04-27  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Mark.
+        
+        <rdar://problem/5154113> Repro ASSERT (would be crash) in KJS::GCLock::GCLock (13462)
+        http://bugs.webkit.org/show_bug.cgi?id=13462
+
+        * WebInspector/WebInspector.m:
+        (-[WebInspectorPrivate dealloc]): Delay release of WebView to avoid GC re-entrancy.
+
 2007-04-27  Anders Carlsson  <andersca@apple.com>
 

trunk/WebKit/WebInspector/WebInspector.m

@@ -513 +513 @@
 - (void)dealloc
 {
-    [webView release];
+    // Releasing our WebView will trigger a garbage collection, but this dealloc is
+    // likely going to happen inside GC and we don't want to re-enter the collector.
+    // Just autorelease is not good enough, because the ObjC bindings code drains the
+    // autorelease pool.
+    [webView performSelector:@selector(release) withObject:nil afterDelay:0];
     [inspectedWebFrame release];
     [currentHighlight release];