Changeset 211451 in webkit
- Timestamp:
- Jan 31, 2017 3:22:56 PM (7 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r211445 r211451 1 2017-01-31 Devin Rousso <dcrousso+webkit@gmail.com> 2 3 Web Inspector: Network tab: provide a way to preserve log on navigation 4 https://bugs.webkit.org/show_bug.cgi?id=166908 5 6 Reviewed by Matt Baker. 7 8 * Localizations/en.lproj/localizedStrings.js: 9 10 * UserInterface/Base/Setting.js: 11 (WebInspector.settings): 12 Add clearNetworkOnNavigate global setting. 13 14 * UserInterface/Views/NetworkGridContentView.css: 15 (.content-view.network-grid > .data-grid .preserved:not(.selected) .cell-content): 16 (.content-view.network-grid > .data-grid .preserved:not(.selected) .cell-content .timeline-record-bar > .segment): 17 * UserInterface/Views/NetworkGridContentView.js: 18 (WebInspector.NetworkGridContentView): 19 (WebInspector.NetworkGridContentView.prototype._mainResourceDidChange): 20 * UserInterface/Views/NetworkSidebarPanel.css: 21 (.sidebar > .panel.navigation.network .tree-outline > .preserved:not(.selected) > :not(.status)): 22 (.sidebar > .panel.navigation.network .tree-outline > .preserved:not(.selected) > .icon): 23 * UserInterface/Views/NetworkSidebarPanel.js: 24 (WebInspector.NetworkSidebarPanel): 25 (WebInspector.NetworkSidebarPanel.prototype._mainResourceDidChange): 26 Add styling to preserved network records. 27 28 * UserInterface/Controllers/TimelineManager.js: 29 (WebInspector.TimelineManager.prototype._mainResourceDidChange): 30 Only reset the persistent network timeline if the clearNetworkOnNavigate setting is true. 31 32 * UserInterface/Views/SettingsTabContentView.js: 33 (WebInspector.SettingsTabContentView.prototype.initialLayout): 34 (WebInspector.SettingsTabContentView): 35 Add checkbox and spacers for new setting. 36 1 37 2017-01-31 Devin Rousso <dcrousso+webkit@gmail.com> 2 38 -
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
r211385 r211451 513 513 localizedStrings["Network Issue"] = "Network Issue"; 514 514 localizedStrings["Network Requests"] = "Network Requests"; 515 localizedStrings["Network:"] = "Network:"; 515 516 localizedStrings["New Rule"] = "New Rule"; 516 517 localizedStrings["New Tab"] = "New Tab"; -
trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js
r210793 r211451 111 111 showInvalidCharacters: new WebInspector.Setting("show-invalid-characters", false), 112 112 clearLogOnNavigate: new WebInspector.Setting("clear-log-on-navigate", true), 113 clearNetworkOnNavigate: new WebInspector.Setting("clear-network-on-navigate", true), 113 114 zoomFactor: new WebInspector.Setting("zoom-factor", 1), 114 115 }; -
trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js
r208520 r211451 805 805 { 806 806 let frame = event.target; 807 if (frame.isMainFrame() )807 if (frame.isMainFrame() && WebInspector.settings.clearNetworkOnNavigate.value) 808 808 this._persistentNetworkTimeline.reset(); 809 809 -
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.css
r199747 r211451 35 35 border-top: none; 36 36 } 37 38 .content-view.network-grid > .data-grid .preserved:not(.selected) .cell-content { 39 opacity: 0.5; 40 } 41 42 .content-view.network-grid > .data-grid .preserved:not(.selected) .cell-content .timeline-record-bar > .segment { 43 filter: grayscale(); 44 } -
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkGridContentView.js
r211075 r211451 33 33 super(representedObject); 34 34 35 WebInspector.Frame.addEventListener(WebInspector.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this); 36 35 37 this._networkSidebarPanel = extraArguments.networkSidebarPanel; 36 38 … … 249 251 } 250 252 253 _mainResourceDidChange(event) 254 { 255 let frame = event.target; 256 if (!frame.isMainFrame() || WebInspector.settings.clearNetworkOnNavigate.value) 257 return; 258 259 for (let dataGridNode of this._dataGrid.children) 260 dataGridNode.element.classList.add("preserved"); 261 } 262 251 263 _networkTimelineReset(event) 252 264 { -
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.css
r204491 r211451 96 96 background-size: 100% 40px; 97 97 } 98 99 .sidebar > .panel.navigation.network .tree-outline > .preserved:not(.selected) > :not(.status) { 100 opacity: 0.5; 101 } 102 103 .sidebar > .panel.navigation.network .tree-outline > .preserved:not(.selected) > .icon { 104 filter: grayscale(); 105 } -
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js
r210759 r211451 30 30 super("network", WebInspector.UIString("Network"), false); 31 31 32 WebInspector.Frame.addEventListener(WebInspector.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this); 33 32 34 this.contentBrowser = contentBrowser; 33 35 … … 172 174 // Private 173 175 176 _mainResourceDidChange(event) 177 { 178 let frame = event.target; 179 if (!frame.isMainFrame() || WebInspector.settings.clearNetworkOnNavigate.value) 180 return; 181 182 for (let treeElement of this.contentTreeOutline.children) 183 treeElement.element.classList.add("preserved"); 184 } 185 174 186 _networkTimelineReset(event) 175 187 { -
trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
r210793 r211451 153 153 this.element.appendChild(document.createElement("br")); 154 154 155 createContainer(WebInspector.UIString("Network:"), (valueControllerContainer) => { 156 let checkbox = createCheckbox(WebInspector.settings.clearNetworkOnNavigate); 157 valueControllerContainer.appendChild(checkbox); 158 159 valueControllerContainer.append(WebInspector.UIString("Clear when page navigates")); 160 }); 161 162 this.element.appendChild(document.createElement("br")); 163 155 164 createContainer(WebInspector.UIString("Console:"), (valueControllerContainer) => { 156 165 let checkbox = createCheckbox(WebInspector.settings.clearLogOnNavigate);
Note: See TracChangeset
for help on using the changeset viewer.