Changeset 211730 in webkit

Timestamp:

Feb 6, 2017 9:35:12 AM (7 years ago)

Author:

Antti Koivisto

Message:

CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::Node::invalidateStyle
​https://bugs.webkit.org/show_bug.cgi?id=167878
rdar://problem/30251840

Reviewed by Andreas Kling.

Speculative fix.

We are trying to invalidate a null node from ~PostResolutionCallbackDisabler. Looks like the only way
this could happen is if HTMLFrameOwnerElement::scheduleinvalidateStyleAndLayerComposition is called
with null 'this'. There is one place where this might happen.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::attachRootLayer): Add null check.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderLayerCompositor.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-02-06  Antti Koivisto  <antti@apple.com>
+
+        CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::Node::invalidateStyle
+        https://bugs.webkit.org/show_bug.cgi?id=167878
+        rdar://problem/30251840
+
+        Reviewed by Andreas Kling.
+
+        Speculative fix.
+
+        We are trying to invalidate a null node from ~PostResolutionCallbackDisabler. Looks like the only way
+        this could happen is if HTMLFrameOwnerElement::scheduleinvalidateStyleAndLayerComposition is called
+        with null 'this'. There is one place where this might happen.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::attachRootLayer): Add null check.
+
 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -3460 +3460 @@
             // The layer will get hooked up via RenderLayerBacking::updateConfiguration()
             // for the frame's renderer in the parent document.
-            m_renderView.document().ownerElement()->scheduleinvalidateStyleAndLayerComposition();
+            if (auto* ownerElement = m_renderView.document().ownerElement())
+                ownerElement->scheduleinvalidateStyleAndLayerComposition();
             break;
         }