Changeset 211815 in webkit


Ignore:
Timestamp:
Feb 7, 2017 10:04:50 AM (7 years ago)
Author:
Carlos Garcia Campos
Message:

[GStreamer] Deadlock when media player is destroyed
https://bugs.webkit.org/show_bug.cgi?id=167861

Reviewed by Michael Catanzaro.

The problem is that we are calling notifyOne() for the draw mutex without taking the lock.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::repaint):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r211814 r211815  
     12017-02-07  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GStreamer] Deadlock when media player is destroyed
     4        https://bugs.webkit.org/show_bug.cgi?id=167861
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        The problem is that we are calling notifyOne() for the draw mutex without taking the lock.
     9
     10        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
     11        (WebCore::MediaPlayerPrivateGStreamerBase::repaint):
     12
    1132017-02-07  Zan Dobersek  <zdobersek@igalia.com>
    214
  • trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp

    r211562 r211815  
    712712        client()->setPlatformLayerNeedsDisplay();
    713713#if USE(GSTREAMER_GL)
     714        LockHolder lock(m_drawMutex);
    714715        m_drawCondition.notifyOne();
    715716#endif
     
    721722
    722723#if USE(GSTREAMER_GL) || USE(COORDINATED_GRAPHICS_THREADED)
     724    LockHolder lock(m_drawMutex);
    723725    m_drawCondition.notifyOne();
    724726#endif
Note: See TracChangeset for help on using the changeset viewer.