Changeset 212236 in webkit

Timestamp:

Feb 13, 2017 11:14:46 AM (7 years ago)

Author:

Matt Baker

Message:

REGRESSION(r188138): Web Inspector: cannot edit next/previous DOM attribute by using tab/shift-tab
​https://bugs.webkit.org/show_bug.cgi?id=168120
<rdar://problem/30466065>

Reviewed by Joseph Pecoraro.

DOMTreeElement's attribute editing committed handler shouldn't early return
when a moveDirection has been specified.

• UserInterface/Views/DOMTreeElement.js:

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DOMTreeElement.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-02-13  Matt Baker  <mattbaker@apple.com>
+
+        REGRESSION(r188138): Web Inspector: cannot edit next/previous DOM attribute by using tab/shift-tab
+        https://bugs.webkit.org/show_bug.cgi?id=168120
+        <rdar://problem/30466065>
+
+        Reviewed by Joseph Pecoraro.
+
+        DOMTreeElement's attribute editing committed handler shouldn't early return
+        when a `moveDirection` has been specified.
+
+        * UserInterface/Views/DOMTreeElement.js:
+
 2017-02-12  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js

@@ -961 +961 @@
         this._editing = false;
 
-        if (newText === oldText)
+        if (!moveDirection && newText === oldText)
             return;