Changeset 212270 in webkit

Timestamp:

Feb 13, 2017 6:11:09 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Source/WebCore:
Added the other missing BSTR roles tag names.
​https://bugs.webkit.org/show_bug.cgi?id=165545

Patch by Karim H <​karim@karhm.com> on 2017-02-13
Reviewed by Chris Fleizach.

Test: accessibility/win/bstr-elements-role.html

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::shouldReturnTagNameAsRoleForMSAA):

LayoutTests:
Added the BSTR roles tag test for Windows.
​https://bugs.webkit.org/show_bug.cgi?id=165545

Patch by Karim H <​karim@karhm.com> on 2017-02-13
Reviewed by Chris Fleizach.

• accessibility/win/bstr-elements-role-expected.txt: Added.
• accessibility/win/bstr-elements-role.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/win/bstr-elements-role-expected.txt (added)
• LayoutTests/accessibility/win/bstr-elements-role.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityRenderObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-02-13  Karim H  <karim@karhm.com>
+
+        Added the BSTR roles tag test for Windows.
+        https://bugs.webkit.org/show_bug.cgi?id=165545
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/win/bstr-elements-role-expected.txt: Added.
+        * accessibility/win/bstr-elements-role.html: Added.
+
 2017-02-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-02-13  Karim H  <karim@karhm.com>
+
+        Added the other missing BSTR roles tag names.
+        https://bugs.webkit.org/show_bug.cgi?id=165545
+
+        Reviewed by Chris Fleizach.
+
+        Test: accessibility/win/bstr-elements-role.html
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::shouldReturnTagNameAsRoleForMSAA):
+
 2017-02-13  Youenn Fablet  <youennf@gmail.com>
 

trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

@@ -3567 +3567 @@
 static bool shouldReturnTagNameAsRoleForMSAA(const Element& element)
 {
-    // See "document structure",
-    // https://wiki.mozilla.org/Accessibility/AT-Windows-API
-    // FIXME: Add the other tag names that should be returned as the role.
-    return element.hasTagName(h1Tag) || element.hasTagName(h2Tag) 
+    return element.hasTagName(abbrTag) || element.hasTagName(acronymTag)
+        || element.hasTagName(blockquoteTag) || element.hasTagName(ddTag)
+        || element.hasTagName(dlTag) || element.hasTagName(dtTag)
+        || element.hasTagName(formTag) || element.hasTagName(frameTag)
+        || element.hasTagName(h1Tag) || element.hasTagName(h2Tag)
         || element.hasTagName(h3Tag) || element.hasTagName(h4Tag)
-        || element.hasTagName(h5Tag) || element.hasTagName(h6Tag);
+        || element.hasTagName(h5Tag) || element.hasTagName(h6Tag)
+        || element.hasTagName(iframeTag) || element.hasTagName(qTag)
+        || element.hasTagName(tbodyTag) || element.hasTagName(tfootTag)
+        || element.hasTagName(theadTag);
 }