Changeset 212400 in webkit


Ignore:
Timestamp:
Feb 15, 2017 2:48:35 PM (7 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: Split console should be allowed when docked bottom on Elements/Resources/Debugger/Storage tabs
​https://bugs.webkit.org/show_bug.cgi?id=168385

Patch by Devin Rousso <Devin Rousso> on 2017-02-15
Reviewed by Timothy Hatcher.

  • UserInterface/Base/Main.js:

(WebInspector.updateDockedState):
If the new docked configuration does not support the split console, hide it.

  • UserInterface/Views/DebuggerTabContentView.js:

(WebInspector.DebuggerTabContentView.prototype.get supportsSplitContentBrowser):

  • UserInterface/Views/ElementsTabContentView.js:

(WebInspector.ElementsTabContentView.prototype.get supportsSplitContentBrowser):

  • UserInterface/Views/ResourcesTabContentView.js:

(WebInspector.ResourcesTabContentView.prototype.get supportsSplitContentBrowser):

  • UserInterface/Views/StorageTabContentView.js:

(WebInspector.StorageTabContentView.prototype.get supportsSplitContentBrowser):

Location:
trunk/Source/WebInspectorUI
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r212339 r212400  
     12017-02-15  Devin Rousso  <dcrousso+webkit@gmail.com>
     2
     3        Web Inspector: Split console should be allowed when docked bottom on Elements/Resources/Debugger/Storage tabs
     4        https://bugs.webkit.org/show_bug.cgi?id=168385
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        * UserInterface/Base/Main.js:
     9        (WebInspector.updateDockedState):
     10        If the new docked configuration does not support the split console, hide it.
     11
     12        * UserInterface/Views/DebuggerTabContentView.js:
     13        (WebInspector.DebuggerTabContentView.prototype.get supportsSplitContentBrowser):
     14        * UserInterface/Views/ElementsTabContentView.js:
     15        (WebInspector.ElementsTabContentView.prototype.get supportsSplitContentBrowser):
     16        * UserInterface/Views/ResourcesTabContentView.js:
     17        (WebInspector.ResourcesTabContentView.prototype.get supportsSplitContentBrowser):
     18        * UserInterface/Views/StorageTabContentView.js:
     19        (WebInspector.StorageTabContentView.prototype.get supportsSplitContentBrowser):
     20
    1212017-02-14  Brian Burg  <bburg@apple.com>
    222

  • trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

    r211976 r212400  
    767767    this._updateDockNavigationItems();
    768768
    769     if (!this.dockedConfigurationSupportsSplitContentBrowser() && this.isShowingSplitConsole())
     769    if (!this.dockedConfigurationSupportsSplitContentBrowser() && !this.doesCurrentTabSupportSplitContentBrowser())
    770770        this.hideSplitConsole();
    771771};

  • trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js

    r208091 r212400  
    5050    }
    5151
     52    get supportsSplitContentBrowser()
     53    {
     54        return true;
     55    }
     56
    5257    canShowRepresentedObject(representedObject)
    5358    {

  • trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js

    r212142 r212400  
    5959    {
    6060        return WebInspector.ElementsTabContentView.Type;
     61    }
     62
     63    get supportsSplitContentBrowser()
     64    {
     65        return true;
    6166    }
    6267

  • trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js

    r208441 r212400  
    5555    }
    5656
     57    get supportsSplitContentBrowser()
     58    {
     59        return true;
     60    }
     61
    5762    canShowRepresentedObject(representedObject)
    5863    {

  • trunk/Source/WebInspectorUI/UserInterface/Views/StorageTabContentView.js

    r208091 r212400  
    5555    }
    5656
     57    get supportsSplitContentBrowser()
     58    {
     59        return true;
     60    }
     61
    5762    canShowRepresentedObject(representedObject)
    5863    {
Note: See TracChangeset for help on using the changeset viewer.