Changeset 213225 in webkit

Timestamp:

Mar 1, 2017 9:23:37 AM (7 years ago)

Author:

ap@apple.com

Message:

IndexedDB.IndexedDBMultiProcess is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=160780

Reviewed by Brady Eidson.

• TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Releasing the object

once doesn't necessarily deallocate the object, there can be other references.
We can use -[WKWebView _close] or -[WKWebView _killWebContentProcessAndResetState].
The latter seems more appropriate, because "kill" is what the comment says.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-03-01  Alexey Proskuryakov  <ap@apple.com>
+
+        IndexedDB.IndexedDBMultiProcess is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=160780
+
+        Reviewed by Brady Eidson.
+
+        * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Releasing the object
+        once doesn't necessarily deallocate the object, there can be other references.
+        We can use -[WKWebView _close] or -[WKWebView _killWebContentProcessAndResetState].
+        The latter seems more appropriate, because "kill" is what the comment says.
+
 2017-02-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm

@@ -32 +32 @@
 #import <WebKit/WKUserContentControllerPrivate.h>
 #import <WebKit/WKWebViewConfigurationPrivate.h>
+#import <WebKit/WKWebViewPrivate.h>
 #import <WebKit/_WKProcessPoolConfiguration.h>
 #import <WebKit/_WKUserStyleSheet.h>
@@ -107 +108 @@
 
     // Kill the blocking web process
-    webView2 = nil;
+    [webView2 _killWebContentProcessAndResetState];
 
     RetainPtr<NSString> string7 = (NSString *)[getNextMessage() body];