Changeset 213270 in webkit

Timestamp:

Mar 1, 2017 11:20:12 PM (7 years ago)

Author:

pvollan@apple.com

Message:

[Win] DRT should not dispatch messages after test is done.
​https://bugs.webkit.org/show_bug.cgi?id=169026

Reviewed by Brent Fulgham.

Exiting the message loop with PostQuitMessage will leave room for
a few messages to be dispatched after the test is done.

• DumpRenderTree/win/DumpRenderTree.cpp:

(dump):
(runTest):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/win/DumpRenderTree.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-03-01  Per Arne Vollan  <pvollan@apple.com>
+
+        [Win] DRT should not dispatch messages after test is done.
+        https://bugs.webkit.org/show_bug.cgi?id=169026
+
+        Reviewed by Brent Fulgham.
+
+        Exiting the message loop with PostQuitMessage will leave room for
+        a few messages to be dispatched after the test is done.
+
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (dump):
+        (runTest):
+
 2017-03-01  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp

@@ -744 +744 @@
 fail:
     // This will exit from our message loop.
-    ::PostQuitMessage(0);
     done = true;
 }
@@ -1212 +1211 @@
     frame->loadRequest(request.get());
 
-    while (true) {
+    while (!done) {
 #if USE(CF)
         CFRunLoopRunInMode(kCFRunLoopDefaultMode, 0, true);