Changeset 213276 in webkit

Timestamp:

Mar 2, 2017 3:44:41 AM (7 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Crash in WebCore::CoordinatedGraphicsLayer::notifyFlushRequired
​https://bugs.webkit.org/show_bug.cgi?id=166420

Reviewed by Žan Doberšek.

This is happening when closing a page that is being inspected. When CoordinatedGraphicsLayer::removeFromParent()
is called, the coordinator has already been invalidated, so all its layers were set a nullptr coordinator. I
think it's safe to simply handle m_coordinator being nullptr in notifyFlushRequired().

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::notifyFlushRequired): Return early if the coordinator is nullptr.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-03-02  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Crash in WebCore::CoordinatedGraphicsLayer::notifyFlushRequired
+        https://bugs.webkit.org/show_bug.cgi?id=166420
+
+        Reviewed by Žan Doberšek.
+
+        This is happening when closing a page that is being inspected. When CoordinatedGraphicsLayer::removeFromParent()
+        is called, the coordinator has already been invalidated, so all its layers were set a nullptr coordinator. I
+        think it's safe to simply handle m_coordinator being nullptr in notifyFlushRequired().
+
+        * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
+        (WebCore::CoordinatedGraphicsLayer::notifyFlushRequired): Return early if the coordinator is nullptr.
+
 2017-03-02  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp

@@ -54 +54 @@
 void CoordinatedGraphicsLayer::notifyFlushRequired()
 {
-    ASSERT(m_coordinator);
+    if (!m_coordinator)
+        return;
+
     if (m_coordinator->isFlushingLayerChanges())
         return;