Changeset 213346 in webkit

Timestamp:

Mar 2, 2017 8:27:42 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[iOS Release WK2] LayoutTest media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=168343
<rdar://problem/30823389>

Patch by Antoine Quint <Antoine Quint> on 2017-03-02
Reviewed by Simon Fraser.

Use an asynchronous assertion to ensure we have valid metrics before pressing the skip back button.

• media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt:
• media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html:
• platform/ios-simulator/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt (modified) (1 diff)
• media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html (modified) (1 diff)
• platform/ios-simulator/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-03-02  Antoine Quint  <graouts@apple.com>
+
+        [iOS Release WK2] LayoutTest media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=168343
+        <rdar://problem/30823389>
+
+        Reviewed by Simon Fraser.
+
+        Use an asynchronous assertion to ensure we have valid metrics before pressing the skip back button.
+
+        * media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt:
+        * media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html:
+        * platform/ios-simulator/TestExpectations:
+
 2017-03-02  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt

@@ -4 +4 @@
 
 
+PASS window.internals.shadowRoot(media).querySelector('button.skip-back').getBoundingClientRect().width became different from 0
 PASS window.internals.shadowRoot(media).querySelector('.controls-bar').classList.contains('faded') is false
 PASS successfullyParsed is true

trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html

@@ -13 +13 @@
 
 media.addEventListener("play", event => {
-    pressOnElement(window.internals.shadowRoot(media).querySelector("button.skip-back"), () => {
-        window.requestAnimationFrame(() => {
-            shouldBeFalse("window.internals.shadowRoot(media).querySelector('.controls-bar').classList.contains('faded')");
-            finishJSTest();
+    shouldBecomeDifferent("window.internals.shadowRoot(media).querySelector('button.skip-back').getBoundingClientRect().width", "0", () => {
+        pressOnElement(window.internals.shadowRoot(media).querySelector("button.skip-back"), () => {
+            window.requestAnimationFrame(() => {
+                shouldBeFalse("window.internals.shadowRoot(media).querySelector('.controls-bar').classList.contains('faded')");
+                finishJSTest();
+            });
         });
     });

trunk/LayoutTests/platform/ios-simulator/TestExpectations

@@ -2849 +2849 @@
 media/modern-media-controls/media-controller/media-controller-toggle-compact-mode.html [ Skip ]
 
-webkit.org/b/168343 media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html [ Pass Timeout ]
-
 webkit.org/b/168668 media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html [ Pass Failure ]