Changeset 213348 in webkit


Ignore:
Timestamp:
Mar 2, 2017 8:47:31 PM (7 years ago)
Author:
commit-queue@webkit.org
Message:

[ios-simulator Debug WK2] LayoutTest media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=168668
<rdar://problem/30823677>

Patch by Antoine Quint <Antoine Quint> on 2017-03-02
Reviewed by Simon Fraser.

This test would sometime fail for the first assertion because we may need more than just metadata
to determine that we can be in a state where the fullscreen button becomes enabled (see the logic
in FullscreenSupport). So we now use an asynchronous assertion to determine we've enabled the
fullscreen button and then force it to error to disable it.

  • media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt:
  • media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html:
  • platform/ios-simulator/TestExpectations:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r213346 r213348  
     12017-03-02  Antoine Quint  <graouts@apple.com>
     2
     3        [ios-simulator Debug WK2] LayoutTest media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html is a flaky failure
     4        https://bugs.webkit.org/show_bug.cgi?id=168668
     5        <rdar://problem/30823677>
     6
     7        Reviewed by Simon Fraser.
     8
     9        This test would sometime fail for the first assertion because we may need more than just metadata
     10        to determine that we can be in a state where the fullscreen button becomes enabled (see the logic
     11        in FullscreenSupport). So we now use an asynchronous assertion to determine we've enabled the
     12        fullscreen button and then force it to error to disable it.
     13
     14        * media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt:
     15        * media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html:
     16        * platform/ios-simulator/TestExpectations:
     17
    1182017-03-02  Antoine Quint  <graouts@apple.com>
    219

  • trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt

    r208274 r213348  
    44
    55
    6 PASS mediaController.controls.fullscreenButton.enabled is true
     6Once media loads and we have tracks in the video, the fullscreen button should become enabled
     7PASS mediaController.controls.fullscreenButton.enabled became true
     8
     9We now set the media source to be the empty string to force an error, which should disable the fullscreen button
    710PASS mediaController.controls.fullscreenButton.enabled is false
    811

  • trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html

    r208274 r213348  
    2828const mediaController = createControls(container, media, null);
    2929
    30 media.addEventListener("loadedmetadata", () => {
    31     shouldBeTrue("mediaController.controls.fullscreenButton.enabled");
     30debug("Once media loads and we have tracks in the video, the fullscreen button should become enabled");
     31shouldBecomeEqual("mediaController.controls.fullscreenButton.enabled", "true", () => {
     32    media.addEventListener("error", () => {
     33        shouldBeFalse("mediaController.controls.fullscreenButton.enabled");
     34        debug("");
     35        container.remove();
     36        media.remove();
     37        finishJSTest();
     38    });
     39    debug("");
     40    debug("We now set the media source to be the empty string to force an error, which should disable the fullscreen button");
    3241    media.src = "";
    33 });
    34 
    35 media.addEventListener("error", () => {
    36     shouldBeFalse("mediaController.controls.fullscreenButton.enabled");
    37     debug("");
    38     container.remove();
    39     media.remove();
    40     finishJSTest();
    4142});
    4243

  • trunk/LayoutTests/platform/ios-simulator/TestExpectations

    r213346 r213348  
    28492849media/modern-media-controls/media-controller/media-controller-toggle-compact-mode.html [ Skip ]
    28502850
    2851 webkit.org/b/168668 media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html [ Pass Failure ]
    2852 
    28532851# Form validation popover does not obey minimum font size setting on iOS but Dynamic Type instead.
    28542852fast/forms/validation-message-minimum-font-size.html [ Skip ]
Note: See TracChangeset for help on using the changeset viewer.