Changeset 213364 in webkit


Ignore:
Timestamp:
Mar 3, 2017 5:07:45 AM (7 years ago)
Author:
commit-queue@webkit.org
Message:

LayoutTest media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=167275
<rdar://problem/30824290>

Patch by Antoine Quint <Antoine Quint> on 2017-03-03
Reviewed by Dean Jackson.

Ensure that we have metrics for buttons before attempting to click on them and let dragging interaction
apply changes to CSS on the next rAF before trying to pursue the next step.

  • media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls-expected.txt:
  • media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html:
  • platform/mac/TestExpectations:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r213362 r213364  
     12017-03-03  Antoine Quint  <graouts@apple.com>
     2
     3        LayoutTest media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html is flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=167275
     5        <rdar://problem/30824290>
     6
     7        Reviewed by Dean Jackson.
     8
     9        Ensure that we have metrics for buttons before attempting to click on them and let dragging interaction
     10        apply changes to CSS on the next rAF before trying to pursue the next step.
     11
     12        * media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls-expected.txt:
     13        * media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html:
     14        * platform/mac/TestExpectations:
     15
    1162017-03-03  Joseph Pecoraro  <pecoraro@apple.com>
    217

  • trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls-expected.txt

    r210959 r213364  
    44
    55
    6 PASS shadowRoot.querySelector('button.tracks').getBoundingClientRect().right === shadowRoot.querySelector('.tracks-panel').getBoundingClientRect().right is true
     6PASS shadowRoot.querySelector('button.fullscreen').getBoundingClientRect() became different from 0
     7PASS shadowRoot.querySelector('button.tracks').getBoundingClientRect() became different from 0
     8PASS shadowRoot.querySelector('button.tracks').getBoundingClientRect().right is shadowRoot.querySelector('.tracks-panel').getBoundingClientRect().right
    79PASS shadowRoot.querySelector('.tracks-panel').style.bottom is "151px"
    810

  • trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html

    r211806 r213364  
    11<!DOCTYPE html>
    22<script src="../../../resources/js-test-pre.js"></script>
     3<script src="../resources/media-controls-utils.js" type="text/javascript"></script>
    34<body>
    45<video src="../../content/CC+Subtitles.mov" style="width: 320px; height: 240px;" controls autoplay></video>
    … …  
    1718
    1819media.addEventListener("webkitfullscreenchange", () => {
    19     if (media.webkitDisplayingFullscreen) {
    20         window.requestAnimationFrame(() => {
    21             const bounds = shadowRoot.querySelector(".controls-bar").getBoundingClientRect();
    22             eventSender.mouseMoveTo(bounds.left + 118, bounds.top + 10);
    23             eventSender.mouseDown();
    24             eventSender.mouseMoveTo(bounds.left + 68, bounds.top - 40);
    25             eventSender.mouseUp();
     20    if (!media.webkitDisplayingFullscreen)
     21        return;
    2622
    27             window.requestAnimationFrame(() => {
    28                 window.requestAnimationFrame(() => {
    29                     clickOnButton("tracks");
    30                     window.requestAnimationFrame(() => {
    31                         shouldBeTrue("shadowRoot.querySelector('button.tracks').getBoundingClientRect().right === shadowRoot.querySelector('.tracks-panel').getBoundingClientRect().right");
    32                         shouldBeEqualToString("shadowRoot.querySelector('.tracks-panel').style.bottom", "151px");
     23    window.requestAnimationFrame(() => {
     24        const bounds = shadowRoot.querySelector(".controls-bar").getBoundingClientRect();
     25        eventSender.mouseMoveTo(bounds.left + 118, bounds.top + 10);
     26        eventSender.mouseDown();
     27        eventSender.mouseMoveTo(bounds.left + 68, bounds.top - 40);
     28        eventSender.mouseUp();
    3329
    34                         debug("");
    35                         media.remove();
    36                         finishJSTest();
    37                     });
     30        requestAnimationFrame(() => {
     31            clickOnButton("tracks", () => {
     32                requestAnimationFrame(() => {
     33                    shouldBe("shadowRoot.querySelector('button.tracks').getBoundingClientRect().right", "shadowRoot.querySelector('.tracks-panel').getBoundingClientRect().right")
     34                    shouldBeEqualToString("shadowRoot.querySelector('.tracks-panel').style.bottom", "151px");
     35
     36                    debug("");
     37                    media.remove();
     38                    finishJSTest();
    3839                });
    3940            });
    4041        });
    41     }
     42    });
    4243});
    4344
    … …  
    4748});
    4849
    49 function clickOnButton(name)
     50function clickOnButton(name, continuation)
    5051{
    51     const bounds = shadowRoot.querySelector(`button.${name}`).getBoundingClientRect();
    52     eventSender.mouseMoveTo(bounds.left + 1, bounds.top + 1);
    53     eventSender.mouseDown();
    54     eventSender.mouseUp();
     52    shouldBecomeDifferent(`shadowRoot.querySelector('button.${name}').getBoundingClientRect()`, "0", () => {
     53        pressOnElement(shadowRoot.querySelector(`button.${name}`), continuation);
     54    });
    5555}
    5656

  • trunk/LayoutTests/platform/mac/TestExpectations

    r213342 r213364  
    14821482media/modern-media-controls/media-controller/media-controller-tight-padding.html [ Skip ]
    14831483
    1484 webkit.org/b/167275 media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html [ Pass Failure ]
    1485 
    14861484webkit.org/b/167266 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Pass Failure ]
    14871485
Note: See TracChangeset for help on using the changeset viewer.