Changeset 213630 in webkit

Timestamp:

Mar 8, 2017 10:02:32 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Fix error/warning duplication in JSON bindings results
​https://bugs.webkit.org/show_bug.cgi?id=169305

Patch by Srinivasan Vijayaraghavan <​svijayaraghavan@apple.com> on 2017-03-08
Reviewed by Alexey Proskuryakov.

The distinction between failures and errors is not meaningful, since all errors will also be failures.
As a result, we only need to keep track of failures.

• Scripts/webkitpy/bindings/main.py:

(BindingsTests.init): Remove errors.
(BindingsTests.detect_changes): Remove errors.
(BindingsTests.main): Remove errors.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/bindings/main.py (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-03-08  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
+
+        Fix error/warning duplication in JSON bindings results
+        https://bugs.webkit.org/show_bug.cgi?id=169305
+
+        Reviewed by Alexey Proskuryakov.
+
+        The distinction between failures and errors is not meaningful, since all errors will also be failures.
+        As a result, we only need to keep track of failures.
+        
+        * Scripts/webkitpy/bindings/main.py:
+        (BindingsTests.__init__): Remove errors.
+        (BindingsTests.detect_changes): Remove errors.
+        (BindingsTests.main): Remove errors.
+
 2017-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Tools/Scripts/webkitpy/bindings/main.py

@@ -47 +47 @@
         if self.json_file_name:
             self.failures = []
-            self.errors = []
 
     def generate_from_idl(self, generator, idl_file, output_directory, supplemental_dependency_file):
@@ -116 +115 @@
                 output = e.output
                 exit_code = e.exit_code
-                if self.json_file_name:
-                    self.errors.append("(%s) %s" % (generator, output_file))
 
             if exit_code or output:
@@ -204 +201 @@
             json_data = {
                 'failures': self.failures,
-                'errors': self.errors,
             }