Changeset 213916 in webkit


Ignore:
Timestamp:
Mar 14, 2017 10:58:09 AM (7 years ago)
Author:
beidson@apple.com
Message:

REGRESSION (r213877): WebKit2.CookieManager fails.
​https://bugs.webkit.org/show_bug.cgi?id=169581

Reviewed by Tim Horton.

Source/WebKit2:

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::processPoolDestroyed): Invalidate the new sets of callbacks.
(WebKit::WebCookieManagerProxy::processDidClose): Ditto.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Reenable the test.
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r213915 r213916  
     12017-03-14  Brady Eidson  <beidson@apple.com>
     2
     3        REGRESSION (r213877): WebKit2.CookieManager fails.
     4        https://bugs.webkit.org/show_bug.cgi?id=169581
     5
     6        Reviewed by Tim Horton.
     7
     8        * UIProcess/WebCookieManagerProxy.cpp:
     9        (WebKit::WebCookieManagerProxy::processPoolDestroyed): Invalidate the new sets of callbacks.
     10        (WebKit::WebCookieManagerProxy::processDidClose): Ditto.
     11
    1122017-03-14  Tomas Popela  <tpopela@redhat.com>
    213

  • trunk/Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp

    r213877 r213916  
    7474    invalidateCallbackMap(m_arrayCallbacks, CallbackBase::Error::OwnerWasInvalidated);
    7575    invalidateCallbackMap(m_httpCookieAcceptPolicyCallbacks, CallbackBase::Error::OwnerWasInvalidated);
     76    invalidateCallbackMap(m_voidCallbacks, CallbackBase::Error::OwnerWasInvalidated);
     77    invalidateCallbackMap(m_getCookiesCallbacks, CallbackBase::Error::OwnerWasInvalidated);
    7678}
    7779
    … …  
    8082    invalidateCallbackMap(m_arrayCallbacks, CallbackBase::Error::ProcessExited);
    8183    invalidateCallbackMap(m_httpCookieAcceptPolicyCallbacks, CallbackBase::Error::ProcessExited);
     84    invalidateCallbackMap(m_voidCallbacks, CallbackBase::Error::ProcessExited);
     85    invalidateCallbackMap(m_getCookiesCallbacks, CallbackBase::Error::ProcessExited);
    8286}
    8387
    … …  
    8690    invalidateCallbackMap(m_arrayCallbacks, CallbackBase::Error::ProcessExited);
    8791    invalidateCallbackMap(m_httpCookieAcceptPolicyCallbacks, CallbackBase::Error::ProcessExited);
     92    invalidateCallbackMap(m_voidCallbacks, CallbackBase::Error::ProcessExited);
     93    invalidateCallbackMap(m_getCookiesCallbacks, CallbackBase::Error::ProcessExited);
    8894}
    8995

  • trunk/Tools/ChangeLog

    r213902 r213916  
     12017-03-14  Brady Eidson  <beidson@apple.com>
     2
     3        REGRESSION (r213877): WebKit2.CookieManager fails.
     4        https://bugs.webkit.org/show_bug.cgi?id=169581
     5
     6        Reviewed by Tim Horton.
     7
     8        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Reenable the test.
     9
    1102017-03-14  Wenson Hsieh  <wenson_hsieh@apple.com>
    211

  • trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

    r213898 r213916  
    154154                51CD1C721B38D48400142CA5 /* modal-alerts-in-new-about-blank-window.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 51CD1C711B38D48400142CA5 /* modal-alerts-in-new-about-blank-window.html */; };
    155155                51D124981E763B02002B2820 /* WKHTTPCookieStorage.mm in Sources */ = {isa = PBXBuildFile; fileRef = 51D124971E763AF8002B2820 /* WKHTTPCookieStorage.mm */; };
     156                51D1249B1E785425002B2820 /* CookieManager.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F6F3F29013342FEB00A6BF19 /* CookieManager.cpp */; };
    156157                51E5C7021919C3B200D8B3E1 /* simple2.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 51E780361919AFF8001829A2 /* simple2.html */; };
    157158                51E5C7031919C3B200D8B3E1 /* simple3.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 51E780371919AFF8001829A2 /* simple3.html */; };
    … …  
    26602661                                5C0BF8951DD599CD00B00328 /* NavigatorLanguage.mm in Sources */,
    26612662                                A1DF74321C41B65800A2F4D0 /* AlwaysRevalidatedURLSchemes.mm in Sources */,
     2663                                51D1249B1E785425002B2820 /* CookieManager.cpp in Sources */,
    26622664                                2DE71AFE1D49C0BD00904094 /* AnimatedResize.mm in Sources */,
    26632665                                7CCE7EB41A411A7E00447C4C /* AttributedString.mm in Sources */,
Note: See TracChangeset for help on using the changeset viewer.