Changeset 213926 in webkit

Timestamp:

Mar 14, 2017 12:16:36 PM (7 years ago)

Author:

Jonathan Bedard

Message:

webkitpy: Efficient app installation for device testing
​https://bugs.webkit.org/show_bug.cgi?id=169054
<rdar://problem/30790207>

Reviewed by Daniel Bates.

We should only install an app on a device once, not every time the app is run.
Move app installation to setup.

• Scripts/webkitpy/port/ios.py:

(IOSPort.setup_test_run): Install app to device.

• Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.init): Remove app installation.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/ios.py (modified) (1 diff)
• Scripts/webkitpy/port/simulator_process.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-03-14  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: Efficient app installation for device testing
+        https://bugs.webkit.org/show_bug.cgi?id=169054
+        <rdar://problem/30790207>
+
+        Reviewed by Daniel Bates.
+
+        We should only install an app on a device once, not every time the app is run.
+        Move app installation to setup.
+
+        * Scripts/webkitpy/port/ios.py:
+        (IOSPort.setup_test_run): Install app to device.
+        * Scripts/webkitpy/port/simulator_process.py:
+        (SimulatorProcess.__init__): Remove app installation.
+
 2017-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Tools/Scripts/webkitpy/port/ios.py

@@ -83 +83 @@
     def setup_test_run(self, device_class=None):
         self._create_devices(device_class)
+
+        for i in xrange(self.child_processes()):
+            device = self.device_for_worker_number(i)
+            _log.debug('Installing to {}'.format(device))
+            # Without passing DYLD_LIBRARY_PATH, libWebCoreTestSupport cannot be loaded and DRT/WKTR will crash pre-launch,
+            # leaving a crash log which will be picked up in results.  No DYLD_FRAMEWORK_PATH will also cause the DRT/WKTR to
+            # crash, but this crash will occur post-launch, after install_app has already killed the process.
+            if not device.install_app(self._path_to_driver(), {'DYLD_LIBRARY_PATH': self._build_path()}):
+                raise RuntimeError('Failed to install app {} on device {}'.format(self._path_to_driver(), device.udid))

trunk/Tools/Scripts/webkitpy/port/simulator_process.py

@@ -60 +60 @@
         self._bundle_id = port_obj.app_identifier_from_bundle(cmd[0])
         self._device = port_obj.device_for_worker_number(worker_number)
-        if not self._device.install_app(cmd[0], env):
-            raise RuntimeError('Failed to install app {} on simulator device {}'.format(cmd[0], self._device.udid))
         env['IPC_IDENTIFIER'] = self._bundle_id + '-' + self._device.udid