Changeset 21393 in webkit

Timestamp:

May 11, 2007 1:51:49 AM (17 years ago)

Author:

bdash

Message:

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

• Fixes ​http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler omits trailing comma in array literal)

• kjs/grammar.y: Add the comma that parser consumes in elision when the array has trailing commas.

2007-05-11 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

• Tests for fix to ​http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler omits trailing comma in array literal)

• fast/js/resources/toString-elision-trailing-comma.js: Added.
• fast/js/toString-elision-trailing-comma-expected.txt: Added.
• fast/js/toString-elision-trailing-comma.html: Added.

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/kjs/grammar.y (modified) (1 diff)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/resources/toString-elision-trailing-comma.js (added)
• LayoutTests/fast/js/toString-elision-trailing-comma-expected.txt (added)
• LayoutTests/fast/js/toString-elision-trailing-comma.html (added)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2007-05-11  Kimmo Kinnunen  <kimmok@iki.fi>
+
+        Reviewed by Darin.
+
+        - Fixes http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler omits trailing
+          comma in array literal)
+
+        * kjs/grammar.y: Add the comma that parser consumes in elision
+          when the array has trailing commas.
+
 2007-05-10  Lars Knoll <lars@trolltech.com>
 

trunk/JavaScriptCore/kjs/grammar.y

@@ -261 +261 @@
     '[' ElisionOpt ']'                  { $$ = new ArrayNode($2); }
   | '[' ElementList ']'                 { $$ = new ArrayNode($2); }
-  | '[' ElementList ',' ElisionOpt ']'  { $$ = new ArrayNode($4, $2); }
+  | '[' ElementList ',' ElisionOpt ']'  { $$ = new ArrayNode($4 + 1, $2); }
 ;
 

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-05-11  Kimmo Kinnunen  <kimmok@iki.fi>
+
+        Reviewed by Darin.
+
+        - Tests for fix to http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler omits
+          trailing comma in array literal)
+
+        * fast/js/resources/toString-elision-trailing-comma.js: Added.
+        * fast/js/toString-elision-trailing-comma-expected.txt: Added.
+        * fast/js/toString-elision-trailing-comma.html: Added.
+
 2007-05-10  Mitz Pettel  <mitz@webkit.org>