Changeset 214170 in webkit


Ignore:
Timestamp:
Mar 20, 2017 8:40:57 AM (7 years ago)
Author:
jonlee@apple.com
Message:

Mark differences in media stream implementation
https://bugs.webkit.org/show_bug.cgi?id=169873

Reviewed by Eric Carlson.

Rearrange IDL and add comments based on 05 February 2017 Editor's Draft of Media
Capture and Streams spec.

  • Modules/mediastream/DOMURLMediaStream.idl:
  • Modules/mediastream/MediaDeviceInfo.idl:
  • Modules/mediastream/MediaDevices.idl:
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamEvent.idl:
  • Modules/mediastream/MediaStreamTrack.idl:
  • Modules/mediastream/MediaStreamTrackEvent.idl:
  • Modules/mediastream/MediaTrackConstraints.idl:
  • Modules/mediastream/MediaTrackSupportedConstraints.idl:
  • Modules/mediastream/NavigatorMediaDevices.idl:
  • Modules/mediastream/NavigatorUserMedia.idl:
Location:
trunk/Source/WebCore
Files:
12 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r214169 r214170  
     12017-03-20  Jon Lee  <jonlee@apple.com>
     2
     3        Mark differences in media stream implementation
     4        https://bugs.webkit.org/show_bug.cgi?id=169873
     5
     6        Reviewed by Eric Carlson.
     7
     8        Rearrange IDL and add comments based on 05 February 2017 Editor's Draft of Media
     9        Capture and Streams spec.
     10        * Modules/mediastream/DOMURLMediaStream.idl:
     11        * Modules/mediastream/MediaDeviceInfo.idl:
     12        * Modules/mediastream/MediaDevices.idl:
     13        * Modules/mediastream/MediaStream.idl:
     14        * Modules/mediastream/MediaStreamEvent.idl:
     15        * Modules/mediastream/MediaStreamTrack.idl:
     16        * Modules/mediastream/MediaStreamTrackEvent.idl:
     17        * Modules/mediastream/MediaTrackConstraints.idl:
     18        * Modules/mediastream/MediaTrackSupportedConstraints.idl:
     19        * Modules/mediastream/NavigatorMediaDevices.idl:
     20        * Modules/mediastream/NavigatorUserMedia.idl:
     21
    1222017-03-20  Per Arne Vollan  <pvollan@apple.com>
    223
  • trunk/Source/WebCore/Modules/mediastream/DOMURLMediaStream.idl

    r206208 r214170  
    2828 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2929 */
     30
     31// FIXME 169871: legacy or remove
    3032[
    3133    Conditional=MEDIA_STREAM
  • trunk/Source/WebCore/Modules/mediastream/MediaDeviceInfo.idl

    r200291 r214170  
    3131] interface MediaDeviceInfo {
    3232    readonly attribute DOMString deviceId;
    33     readonly attribute DOMString groupId;
    3433    readonly attribute MediaDeviceKind kind;
    3534    readonly attribute DOMString label;
     35    readonly attribute DOMString groupId;
     36
     37    // FIXME 169871: missing serializer
    3638};
     39
     40// FIXME 169871: missing InputDeviceInfo
    3741
    3842enum MediaDeviceKind {
  • trunk/Source/WebCore/Modules/mediastream/MediaDevices.idl

    r212323 r214170  
    2929 */
    3030
     31// FIXME 169871: should be subclass of EventTarget
    3132[
    3233    Conditional=MEDIA_STREAM,
    3334    NoInterfaceObject,
    3435] interface MediaDevices {
     36    // FIXME 169872: missing ondevicechange
     37    Promise<sequence<MediaDeviceInfo>> enumerateDevices();
     38
    3539    MediaTrackSupportedConstraints getSupportedConstraints();
    36 
    3740    [PrivateIdentifier, PublicIdentifier] Promise<MediaStream> getUserMedia(optional MediaStreamConstraints constraints);
    38     Promise<sequence<MediaDeviceInfo>> enumerateDevices();
    3941};
    4042
  • trunk/Source/WebCore/Modules/mediastream/MediaStream.idl

    r204336 r214170  
    4747    readonly attribute boolean active;
    4848
    49     attribute EventHandler onactive;
    50     attribute EventHandler oninactive;
    5149    attribute EventHandler onaddtrack;
    5250    attribute EventHandler onremovetrack;
     51
     52    // FIXME 169871: legacy or remove?
     53    attribute EventHandler onactive;
     54    // FIXME 169871: legacy or remove?
     55    attribute EventHandler oninactive;
    5356};
    5457
  • trunk/Source/WebCore/Modules/mediastream/MediaStreamEvent.idl

    r211006 r214170  
    2323 */
    2424
     25// FIXME 169871: legacy or remove
    2526[
    2627    Conditional=WEB_RTC,
  • trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl

    r214042 r214170  
    2424 */
    2525
     26// FIXME 169871: remove "new"
    2627enum MediaStreamTrackState { "new", "live", "ended" };
    2728
     
    4142    attribute EventHandler onmute;
    4243    attribute EventHandler onunmute;
    43     readonly attribute boolean _readonly;
    4444    readonly attribute MediaStreamTrackState readyState;
    4545    attribute EventHandler onended;
     
    4848    [ImplementedAs=stopProducingData] void stop();
    4949
     50    MediaTrackCapabilities getCapabilities();
    5051    MediaTrackConstraints getConstraints();
    5152    MediaTrackSettings getSettings();
    52     MediaTrackCapabilities getCapabilities();
    5353    Promise<void> applyConstraints(optional MediaTrackConstraints constraints);
    5454
    5555    attribute EventHandler onoverconstrained;
     56
     57    // FIXME 169871: legacy or remove?
     58    readonly attribute boolean _readonly;
    5659};
    5760
     
    6972    LongRange sampleSize;
    7073    sequence<boolean> echoCancellation;
    71     // FIXME: add latency
    72     // FIXME: add channelCount
     74    // FIXME 169871: add latency
     75    // FIXME 169871: add channelCount
    7376    DOMString deviceId;
    7477    DOMString groupId;
     
    8891    long sampleSize;
    8992    boolean echoCancellation;
    90     // FIXME: add latency
    91     // FIXME: add channelCount
     93    // FIXME 169871: add latency
     94    // FIXME 169871: add channelCount
    9295    DOMString deviceId;
    9396    DOMString groupId;
  • trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.idl

    r207588 r214170  
    2727    Constructor(DOMString type, MediaStreamTrackEventInit eventInitDict),
    2828] interface MediaStreamTrackEvent : Event {
     29    // FIXME: missing [SameObject]
    2930    readonly attribute MediaStreamTrack track;
    3031};
  • trunk/Source/WebCore/Modules/mediastream/MediaTrackConstraints.idl

    r209959 r214170  
    4444    ConstrainLong sampleSize;
    4545    ConstrainBoolean echoCancellation;
    46     // FIXME: add latency
    47     // FIXME: add channelCount
     46    // FIXME 169871: add latency
     47    // FIXME 169871: add channelCount
    4848    ConstrainDOMString deviceId;
    4949    ConstrainDOMString groupId;
  • trunk/Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.idl

    r209959 r214170  
    4242    boolean sampleSize = true;
    4343    boolean echoCancellation = true;
     44    // FIXME 169871: add latency
     45    // FIXME 169871: add channelCount
    4446    boolean deviceId = true;
    4547    boolean groupId = true;
  • trunk/Source/WebCore/Modules/mediastream/NavigatorMediaDevices.idl

    r211006 r214170  
    3333    EnabledAtRuntime=MediaStream,
    3434] partial interface Navigator {
     35    // FIXME: missing [SameObject]
    3536    readonly attribute MediaDevices mediaDevices;
    3637};
  • trunk/Source/WebCore/Modules/mediastream/NavigatorUserMedia.idl

    r212323 r214170  
    3333    EnabledAtRuntime=MediaStream,
    3434] partial interface Navigator {
     35    // FIXME 169871: wrap legacy setting
    3536    [JSBuiltin] void getUserMedia(MediaStreamConstraints constraints, NavigatorUserMediaSuccessCallback successCallback, NavigatorUserMediaErrorCallback errorCallback);
    3637};
Note: See TracChangeset for help on using the changeset viewer.