Changeset 21448 in webkit

Timestamp:

May 13, 2007 9:45:44 PM (17 years ago)

Author:

ap

Message:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13690
JavaScript Form Validation issue on Banco do Brasil site

Test: fast/forms/input-setvalue-selection.html

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): In other browsers, changing textInput.value always moves the insertion point past the text. In 10.4.9 WebKit, this only worked for inactive controls, and it never worked in ToT.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/input-appearance-maxlength.html (modified) (1 diff)
• LayoutTests/fast/forms/input-selection-restore-expected.txt (deleted)
• LayoutTests/fast/forms/input-selection-restore.html (deleted)
• LayoutTests/fast/forms/input-setvalue-selection-expected.txt (added)
• LayoutTests/fast/forms/input-setvalue-selection.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLInputElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-05-13  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Darin.
+
+        http://bugs.webkit.org/show_bug.cgi?id=13690
+        JavaScript Form Validation issue on Banco do Brasil site
+
+        * fast/forms/input-setvalue-selection-expected.txt: Added.
+        * fast/forms/input-setvalue-selection.html: Added.
+
+        * fast/forms/input-appearance-maxlength.html: Now that the selection is correctly set
+        in inactive text inputs, we need to explicitly change it to exercise the same code path.
+
+        * fast/forms/input-selection-restore-expected.txt: Removed.
+        * fast/forms/input-selection-restore.html: Removed.
+        AFAICT, this test was added in r14931 to test for status quo, and not because we
+        specifically wanted such behavior.
+
 2007-05-13  Rob Buis  <buis@kde.org>
 

trunk/LayoutTests/fast/forms/input-appearance-maxlength.html

@@ -18 +18 @@
     document.getElementById('sp').value = "123";
     
+    document.getElementById('sp').setSelectionRange(0, 3);
     document.getElementById('sp').focus();
     document.execCommand("InsertText", false, 'abcd');

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-05-13  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Darin.
+
+        http://bugs.webkit.org/show_bug.cgi?id=13690
+        JavaScript Form Validation issue on Banco do Brasil site
+
+        Test: fast/forms/input-setvalue-selection.html
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::setValue): In other browsers, changing textInput.value
+        always moves the insertion point past the text. In 10.4.9 WebKit, this only worked
+        for inactive controls, and it never worked in ToT.
+
 2007-05-13  Brady Eidson  <beidson@apple.com>
 

trunk/WebCore/html/HTMLInputElement.cpp

@@ -991 +991 @@
         setAttribute(valueAttr, constrainValue(value));
     
-    // Restore a caret at the starting point of the old selection.
-    // This matches Safari 2.0 behavior.
-    if (isTextField() && document()->focusedNode() == this && cachedSelStart != -1) {
-        ASSERT(cachedSelEnd != -1);
-        setSelectionRange(cachedSelStart, cachedSelStart);
+    if (isTextField()) {
+        unsigned max = m_value.length();
+        if (document()->focusedNode() == this)
+            setSelectionRange(max, max);
+        else {
+            cachedSelStart = max;
+            cachedSelEnd = max;
+        }
     }
 }