Changeset 214551 in webkit

Timestamp:

Mar 29, 2017 11:57:52 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Network tab content view is blank after reload
​https://bugs.webkit.org/show_bug.cgi?id=168029

Patch by Sam Brodkin <​isam@apple.com> on 2017-03-29
Reviewed by Brian Burg.

• UserInterface/Views/NetworkSidebarPanel.js:

(WebInspector.NetworkSidebarPanel.prototype._networkTimelineReset):
showDefaultContentView() which shows networkGridView in the contentView was not being called
when the NetworkSidebarPanel was not visible. Removing the if statement always shows the
networkGridView which fixes the bug. This wouldn't be easy to regression test.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/NetworkSidebarPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-03-29  Sam Brodkin  <isam@apple.com>
+
+        Web Inspector: Network tab content view is blank after reload
+        https://bugs.webkit.org/show_bug.cgi?id=168029
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/NetworkSidebarPanel.js:
+        (WebInspector.NetworkSidebarPanel.prototype._networkTimelineReset):
+        showDefaultContentView() which shows networkGridView in the contentView was not being called
+        when the NetworkSidebarPanel was not visible. Removing the if statement always shows the
+        networkGridView which fixes the bug. This wouldn't be easy to regression test.
+
 2017-03-28  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js

@@ -192 +192 @@
     {
         this.contentBrowser.contentViewContainer.closeAllContentViews();
-
-        if (this.visible)
-            this.showDefaultContentView();
+        this.showDefaultContentView();
     }