Changeset 21473 in webkit

Timestamp:

May 14, 2007 6:53:54 PM (17 years ago)

Author:

bdash

Message:

2007-05-14 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

• Fixes ​http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler omits trailing comma in array literal)

• kjs/nodes2string.cpp: (ArrayNode::streamTo): print extra ',' in case there was elision commas (check opt member var) and array elements present in the array expression

2007-05-14 Kimmo Kinnunen <Kimmo Kinnunen>

Reviewed by Darin.

• Tests for fix to ​http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler omits trailing comma in array literal)

• fast/js/resources/toString-elision-trailing-comma.js: Added.
• fast/js/toString-elision-trailing-comma-expected.txt: Added.
• fast/js/toString-elision-trailing-comma.html: Added.

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/kjs/nodes2string.cpp (modified) (1 diff)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/resources/toString-elision-trailing-comma.js (added)
• LayoutTests/fast/js/toString-elision-trailing-comma-expected.txt (added)
• LayoutTests/fast/js/toString-elision-trailing-comma.html (added)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2007-05-14  Kimmo Kinnunen  <kimmok@iki.fi>
+
+        Reviewed by Darin.
+
+        - Fixes http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler
+          omits trailing comma in array literal)
+
+         * kjs/nodes2string.cpp:
+         (ArrayNode::streamTo): print extra ',' in case there was elision
+         commas (check opt member var) and array elements present
+         in the array expression
+
 2007-05-14  Geoffrey Garen  <ggaren@apple.com>
 

trunk/JavaScriptCore/kjs/nodes2string.cpp

@@ -178 +178 @@
   for (int i = 0; i < elision; i++)
     s << ",";
+  // Parser consumes one elision comma if there's array elements 
+  // present in the expression.
+  if (opt && element)
+    s << ",";
   s << "]";
 }

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-05-14  Kimmo Kinnunen  <kimmok@iki.fi>
+
+        Reviewed by Darin.
+
+        - Tests for fix to http://bugs.webkit.org/show_bug.cgi?id=13622 (Decompiler omits
+          trailing comma in array literal)
+
+        * fast/js/resources/toString-elision-trailing-comma.js: Added.
+        * fast/js/toString-elision-trailing-comma-expected.txt: Added.
+        * fast/js/toString-elision-trailing-comma.html: Added.
+
 2007-05-14  Mitz Pettel  <mitz@webkit.org>